From: Daniel Axtens <dja@axtens.net>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
tlfalcon@linux.vnet.ibm.com
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
stable@vger.kernel.org,
"Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Subject: Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle
Date: Tue, 14 Nov 2017 12:07:01 +1100 [thread overview]
Message-ID: <87wp2t3byi.fsf@linkitivity.dja.id.au> (raw)
In-Reply-To: <20171113230155.99682-1-bryantly@linux.vnet.ibm.com>
Hi Bryant,
A few things:
1) The commit message could probably be trimmed, especially the stack
traces.
2) What exactly are you changing and why does it fix the issue? I
couldn't figure that out from the commit message.
3) Does this need a Fixes: tag?
> }
>
> - netdev->min_mtu = IBMVETH_MIN_MTU;
> - netdev->max_mtu = ETH_MAX_MTU;
> -
4) What does the above hunk do? It seems unrelated...
Regards,
Daniel
next prev parent reply other threads:[~2017-11-14 1:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 23:01 [PATCH] ibmveth: Kernel crash LSO offload flag toggle Bryant G. Ly
2017-11-14 1:07 ` Daniel Axtens [this message]
2017-11-14 15:24 ` Bryant G. Ly
-- strict thread matches above, loose matches on Subject: below --
2017-11-14 15:34 Bryant G. Ly
2017-11-15 2:47 ` Daniel Axtens
2017-11-15 3:14 ` Benjamin Herrenschmidt
2017-11-15 16:45 ` Bryant G. Ly
2017-11-15 21:57 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp2t3byi.fsf@linkitivity.dja.id.au \
--to=dja@axtens.net \
--cc=benh@kernel.crashing.org \
--cc=bryantly@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).