From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Subject: Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle Date: Tue, 14 Nov 2017 12:07:01 +1100 Message-ID: <87wp2t3byi.fsf@linkitivity.dja.id.au> References: <20171113230155.99682-1-bryantly@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, "Bryant G. Ly" To: "Bryant G. Ly" , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, tlfalcon@linux.vnet.ibm.com Return-path: In-Reply-To: <20171113230155.99682-1-bryantly@linux.vnet.ibm.com> Sender: stable-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi Bryant, A few things: 1) The commit message could probably be trimmed, especially the stack traces. 2) What exactly are you changing and why does it fix the issue? I couldn't figure that out from the commit message. 3) Does this need a Fixes: tag? > } > > - netdev->min_mtu = IBMVETH_MIN_MTU; > - netdev->max_mtu = ETH_MAX_MTU; > - 4) What does the above hunk do? It seems unrelated... Regards, Daniel