From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: [PATCH 1/2] ne: Add h8300 support. Date: Fri, 02 Oct 2015 15:04:25 +0900 Message-ID: <87wpv5q00m.wl-ysato@users.sourceforge.jp> References: <1443363556-29937-1-git-send-email-ysato@users.sourceforge.jp> <20150927.125130.1749145249599569463.davem@davemloft.net> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from mail1.asahi-net.or.jp ([202.224.39.197]:56728 "EHLO mail1.asahi-net.or.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbbJBGE1 (ORCPT ); Fri, 2 Oct 2015 02:04:27 -0400 In-Reply-To: <20150927.125130.1749145249599569463.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 28 Sep 2015 04:51:30 +0900, David Miller wrote: > > From: Yoshinori Sato > Date: Sun, 27 Sep 2015 23:19:15 +0900 > > > @@ -88,7 +88,7 @@ config MCF8390 > > config NE2000 > > tristate "NE2000/NE1000 support" > > depends on (ISA || (Q40 && m) || M32R || MACH_TX49XX || \ > > - ATARI_ETHERNEC) > > + ATARI_ETHERNEC || H8300) > ... > > > > -#if defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R) > > +#if defined(CONFIG_PLAT_MAPPI) || defined(CONFIG_PLAT_OAKS32R) || \ > > + defined(CONFIG_H8300_KANEBEBE) || defined(CONFIG_H8300_AE3069) > > It makes no sense to test different config symbols for these two > things. > > Either both should use "H8300" or both should use > "H8300_KANEBEBE || H8300_AE3069". OK. I'll sent v2. -- Yoshinori Sato