From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shuah@kernel.org>, <linux-kselftest@vger.kernel.org>,
<willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines
Date: Fri, 17 Jan 2025 16:16:22 +0100 [thread overview]
Message-ID: <87y0z92z8q.fsf@nvidia.com> (raw)
In-Reply-To: <20250117065323.42daa2f9@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 17 Jan 2025 13:49:23 +0100 Petr Machata wrote:
>> This logging and xfail handling duplicates lib.sh. Would a patch like
>> below be OK with you? The gist of it is to just use check_err, log_test
>> and xfail_on_slow from lib.sh to achieve what the test open-codes.
>
> Hm, maybe? I'm not going to say no if you send a patch, but IMHO
> if we were to change the output I think we should make it ktap.
Hmm, at some point, we'll want to convert lib.sh to ktap as well.
Hopefully transparently so that all the existing selftests out there
just magically become ktap-compatible.
If you want to preserve the output 1:1 then I feel like that's bending
over backwards too much. We could still maybe reuse xfail_on_slow and
ask for FAIL_TO_XFAIL, but that's marked internal in lib.sh. So I
retract my proposal. Too faffy at that point.
next prev parent reply other threads:[~2025-01-17 16:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 2:01 [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines Jakub Kicinski
2025-01-16 11:52 ` Przemek Kitszel
2025-01-16 13:00 ` Willem de Bruijn
2025-01-17 12:49 ` Petr Machata
2025-01-17 14:53 ` Jakub Kicinski
2025-01-17 15:16 ` Petr Machata [this message]
2025-01-18 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0z92z8q.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).