From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Lizhi Xu <lizhi.xu@windriver.com>,
alex.aring@gmail.com, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, stefan@datenfreihafen.org,
syzbot+985f827280dc3a6e7e92@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] mac802154: add a check for slave data list before delete
Date: Wed, 13 Nov 2024 11:58:32 +0100 [thread overview]
Message-ID: <87y11npfhj.fsf@bootlin.com> (raw)
In-Reply-To: <6ff1052f-76d5-42a4-bf0c-ec587ca4faa4@yandex.ru> (Dmitry Antipov's message of "Wed, 13 Nov 2024 13:29:55 +0300")
On 13/11/2024 at 13:29:55 +03, Dmitry Antipov <dmantipov@yandex.ru> wrote:
> On 11/12/24 4:41 PM, Lizhi Xu wrote:
>
>> mutex_lock(&sdata->local->iflist_mtx);
>> + if (list_empty(&sdata->local->interfaces)) {
>> + mutex_unlock(&sdata->local->iflist_mtx);
>> + return;
>> + }
>> list_del_rcu(&sdata->list);
>> mutex_unlock(&sdata->local->iflist_mtx);
>
> Note https://syzkaller.appspot.com/text?tag=ReproC&x=12a9f740580000 makes an
> attempt to connect the only device. How this is expected to work if there are
> more than one device?
Isn't sdata already specific enough? What do you mean by "device"?
Thanks,
Miquèl
next prev parent reply other threads:[~2024-11-13 10:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 16:53 [syzbot] [wpan?] [usb?] BUG: corrupted list in ieee802154_if_remove syzbot
2024-11-08 14:54 ` [PATCH] mac802154: add a check for slave data list before delete Lizhi Xu
2024-11-11 19:46 ` Miquel Raynal
2024-11-12 0:21 ` Lizhi Xu
2024-11-12 4:31 ` [syzbot] [wpan?] [usb?] BUG: corrupted list in ieee802154_if_remove syzbot
2024-11-12 11:01 ` [PATCH] mac802154: add a check for slave data list before delete Miquel Raynal
2024-11-12 13:41 ` Lizhi Xu
2024-11-13 8:26 ` Miquel Raynal
2024-11-13 9:51 ` [PATCH V2] mac802154: check local interfaces before deleting sdata list Lizhi Xu
2024-11-19 10:06 ` Stefan Schmidt
2024-11-13 10:29 ` [PATCH] mac802154: add a check for slave data list before delete Dmitry Antipov
2024-11-13 10:58 ` Miquel Raynal [this message]
2024-11-13 12:45 ` Dmitry Antipov
2024-11-14 1:00 ` Lizhi Xu
2024-11-14 1:17 ` Lizhi Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y11npfhj.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=lizhi.xu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=syzbot+985f827280dc3a6e7e92@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).