From: Petr Machata <petrm@nvidia.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <dsahern@kernel.org>, <idosch@nvidia.com>,
<amcohen@nvidia.com>, <petrm@nvidia.com>, <gnault@redhat.com>,
<b.galvani@gmail.com>, <alce@lafranque.net>,
<shaozhengchao@huawei.com>, <horms@kernel.org>,
<j.granados@samsung.com>, <linux@weissschuh.net>,
<judyhsiao@chromium.org>, <jiri@resnulli.us>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 00/10] net: Delete some redundant judgments
Date: Fri, 23 Aug 2024 15:16:46 +0200 [thread overview]
Message-ID: <87y14nidbs.fsf@nvidia.com> (raw)
In-Reply-To: <20240822043252.3488749-1-lizetao1@huawei.com>
Li Zetao <lizetao1@huawei.com> writes:
> This patchset aims to remove some unnecessary judgments and make the
> code more concise. In some network modules, rtnl_set_sk_err is used to
> record error information, but the err is repeatedly judged to be less
> than 0 on the error path. Deleted these redundant judgments.
What you call "judgments" would be usually called "conditionals" or
"conditional statements", "judged less than zero" would be probably
"compared to zero". I think the commit messages are reasonably clear
despite this, so I'd leave it be unless others push back. But it's worth
keeping in mind for future contributions.
next prev parent reply other threads:[~2024-08-23 13:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 4:32 [PATCH net-next 00/10] net: Delete some redundant judgments Li Zetao
2024-08-22 4:32 ` [PATCH net-next 01/10] net: vxlan: delete redundant judgment statements Li Zetao
2024-08-23 13:13 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 02/10] fib: rules: " Li Zetao
2024-08-23 13:13 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 03/10] neighbour: " Li Zetao
2024-08-23 13:14 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 04/10] rtnetlink: " Li Zetao
2024-08-23 13:14 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 05/10] ipv4: " Li Zetao
2024-08-23 13:14 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 06/10] ipmr: " Li Zetao
2024-08-23 13:15 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 07/10] net: nexthop: " Li Zetao
2024-08-23 13:15 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 08/10] ip6mr: " Li Zetao
2024-08-23 13:15 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 09/10] net/ipv6: " Li Zetao
2024-08-23 13:16 ` Petr Machata
2024-08-22 4:32 ` [PATCH net-next 10/10] net: mpls: " Li Zetao
2024-08-23 13:16 ` Petr Machata
2024-08-23 13:16 ` Petr Machata [this message]
2024-08-24 2:16 ` [PATCH net-next 00/10] net: Delete some redundant judgments Li Zetao
2024-08-23 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y14nidbs.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=alce@lafranque.net \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=j.granados@samsung.com \
--cc=jiri@resnulli.us \
--cc=judyhsiao@chromium.org \
--cc=kuba@kernel.org \
--cc=linux@weissschuh.net \
--cc=lizetao1@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).