From: Jonathan Corbet <corbet@lwn.net>
To: Breno Leitao <leitao@debian.org>,
netdev@vger.kernel.org, donald.hunter@gmail.com, kuba@kernel.org
Cc: leit@meta.com, linux-doc@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: Document each netlink family
Date: Fri, 17 Nov 2023 15:17:02 -0700 [thread overview]
Message-ID: <87y1ew6n4x.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231113202936.242308-1-leitao@debian.org>
Breno Leitao <leitao@debian.org> writes:
> This is a simple script that parses the Netlink YAML spec files
> (Documentation/netlink/specs/), and generates RST files to be rendered
> in the Network -> Netlink Specification documentation page.
>
> Create a python script that is invoked during 'make htmldocs', reads the
> YAML specs located under Documentation/netlink/specs, parses one by one
> and generates a correspondent RST file for each YAML file.
>
> Create a new Documentation/networking/netlink_spec index page, and
> reference each Netlink RST file that was processed above in this main
> index.rst file.
>
> In case of any exception during the parsing, dump the error and skip
> the file.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>
In principle I like this approach better. There is one problem, though:
- In current kernels, on my machine, "make htmldocs" when nothing has
changed takes about 6s to complete.
- With this patch applied, it takes a little over 5 *minutes*.
Without having delved into it too far, I am guessing that the
unconditional recreation of the netlink RST files is causing the rebuild
of much of the documentation. Even so, I don't quite get it.
That, clearly, would need to be fixed before this can go in.
Thanks,
jon
next prev parent reply other threads:[~2023-11-17 22:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 20:29 [PATCH v2] Documentation: Document each netlink family Breno Leitao
2023-11-17 22:17 ` Jonathan Corbet [this message]
2023-11-18 0:39 ` Jakub Kicinski
2023-11-20 19:55 ` Breno Leitao
2023-11-20 20:07 ` Jakub Kicinski
2023-11-20 20:43 ` Breno Leitao
2023-11-20 21:14 ` Jakub Kicinski
2023-11-21 11:17 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1ew6n4x.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).