From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4D2918625 for ; Mon, 13 Nov 2023 09:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="FK7GQuuK" Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AFDD10D3 for ; Mon, 13 Nov 2023 01:15:00 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9d0b4dfd60dso632037366b.1 for ; Mon, 13 Nov 2023 01:15:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1699866899; x=1700471699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=nqAj+/4HsfM/OT/pOYkHTVyOzGslgKaR3cwh79ZR6fY=; b=FK7GQuuK8TWlQ4aD8A94WNnTZoVagDZmt4CC2ey6TH4niJeGb/iZECGBLZgGNGP8uJ jyqz4DjKiq+bynG+Z407+3tqLBj/dMU/b+fSNKBJURs/WvO9DP/b2ADTW+9K4DItm0Bm 8mOfuiaQlDHCutTWsXbpTtCswc2d2U3ydzB78BD+m4JmUCZJiVf6dCVWNsJ5QTVivJpK vXoky4pNn10uMCBBndyaDfm6GgwNN4jZs8lzbNiLXGQMAbEoXLeekEF5r48dgqWaBGZj SOwwGwrbOL5VpBNhMtnIhVtjoqSRoayRfwY41gZRy5sGrvSVtsrVpPAeDnKYEwJs7JQI uAmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699866899; x=1700471699; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nqAj+/4HsfM/OT/pOYkHTVyOzGslgKaR3cwh79ZR6fY=; b=UVhhTN2eYptI8m25SXeP/YmOiMcXqnHh8KalIBGKzpWmWVtuE4nyMQdevn82ntPL0p R43MjYXNd0pDeNqdAzNIi4qxVzttybFSrKX2YVHhd3Dt5wanb1s5ljB3IfrDGleyPR3k Yry941jfV09Z/NM9mMPlvsqnEZgg+pv9jAOvedgdbwYq+Qd9R+3j0zTfcNntvPoWoyO7 Sg+JmyN2c0szmSgkawkQjn6cnw05GY8gkStaY3gBGcmx6OuodJy2gn08fUOmxJU44qmx 6kuOgY10z8DrvzoY/wMu4wVX0fkTfL8zWVPGuQDLrWNdSfdPhPcuasQdFKgxhcx98RwL GQjw== X-Gm-Message-State: AOJu0YyFiAjRPm4iFulVgnZ2j4Hnc2XHoaYz7XiYAo7kKWtUbQPmGDST DHeu1LvyNnY7MBFOhPpo4Y20KpDt/a79SCyo6tM= X-Google-Smtp-Source: AGHT+IF91kjZK5fwVZ7M3Yyq/JWUwfv0MwrVNqHO3XYQbozA8HYRB9ZT/pav1qQGNNomdXGamb7vbg== X-Received: by 2002:a17:906:e4e:b0:9e3:f97b:239e with SMTP id q14-20020a1709060e4e00b009e3f97b239emr4394231eji.29.1699866898707; Mon, 13 Nov 2023 01:14:58 -0800 (PST) Received: from cloudflare.com ([2a09:bac5:5064:2dc::49:1e2]) by smtp.gmail.com with ESMTPSA id lx20-20020a170906af1400b009e5f5efac10sm3655209ejb.208.2023.11.13.01.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 01:14:58 -0800 (PST) References: <1699609302-8605-1-git-send-email-yangpc@wangsu.com> User-agent: mu4e 1.6.10; emacs 28.3 From: Jakub Sitnicki To: Alexei Starovoitov , Pengcheng Yang Cc: John Fastabend , bpf , Network Development Subject: Re: [PATCH bpf-next] bpf, sockmap: Bundle psock->sk_redir and redir_ingress into a tagged pointer Date: Mon, 13 Nov 2023 10:02:49 +0100 In-reply-to: Message-ID: <87y1f2f20f.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Nov 10, 2023 at 07:42 AM -08, Alexei Starovoitov wrote: > On Fri, Nov 10, 2023 at 1:44=E2=80=AFAM Pengcheng Yang wrote: >> >> Like skb->_sk_redir, we bundle the sock redirect pointer and >> the ingress bit to manage them together. >> >> Suggested-by: Jakub Sitnicki >> Link: https://lore.kernel.org/bpf/87cz97cnz8.fsf@cloudflare.com >> Signed-off-by: Pengcheng Yang >> --- >> include/linux/skmsg.h | 30 ++++++++++++++++++++++++++++-- >> net/core/skmsg.c | 18 ++++++++++-------- >> net/ipv4/tcp_bpf.c | 13 +++++++------ >> net/tls/tls_sw.c | 11 ++++++----- >> 4 files changed, 51 insertions(+), 21 deletions(-) >> >> diff --git a/include/linux/skmsg.h b/include/linux/skmsg.h >> index c1637515a8a4..ae021f511f46 100644 >> --- a/include/linux/skmsg.h >> +++ b/include/linux/skmsg.h >> @@ -78,11 +78,10 @@ struct sk_psock_work_state { >> >> struct sk_psock { >> struct sock *sk; >> - struct sock *sk_redir; >> + unsigned long _sk_redir; > > Please don't. > There is no need to bundle them together. Seeing how the code turned out, I agree - it didn't work out. Code is not any simpler. My gut feeling was wrong here. I gotta ask for, for the future, though - this is not a "no" to tagged pointers in general, right?