From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
ajay.kathat@microchip.com
Subject: Re: pull-request: wireless-next-2022-07-29
Date: Mon, 01 Aug 2022 14:08:01 +0300 [thread overview]
Message-ID: <87y1w8mdbi.fsf@kernel.org> (raw)
In-Reply-To: <20220729193858.664c59f4@kernel.org> (Jakub Kicinski's message of "Fri, 29 Jul 2022 19:38:58 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 29 Jul 2022 19:28:32 +0000 (UTC) Kalle Valo wrote:
>> Hi,
>>
>> here's a pull request to net-next tree, more info below. Please let me know if
>> there are any problems.
>
> Sparse complains about this spurious inline:
>
> +++ b/drivers/net/wireless/microchip/wilc1000/hif.h
> @@ -206,13 +206,14 @@ int wilc_get_statistics(struct wilc_vif *vif, struct rf_info *stats);
> void wilc_gnrl_async_info_received(struct wilc *wilc, u8 *buffer, u32 length);
> void *wilc_parse_join_bss_param(struct cfg80211_bss *bss,
> struct cfg80211_crypto_settings *crypto);
> int wilc_set_default_mgmt_key_index(struct wilc_vif *vif, u8 index);
> +inline void wilc_handle_disconnect(struct wilc_vif *vif);
>
> drivers/net/wireless/microchip/wilc1000/hif.h:218:35: error: marked inline, but without a definition
Sorry about that, I missed it during review. Fix submitted now:
https://patchwork.kernel.org/project/linux-wireless/patch/20220801110440.13144-1-kvalo@kernel.org/
You'll get it in the next pull request.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-08-01 11:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 19:28 pull-request: wireless-next-2022-07-29 Kalle Valo
2022-07-30 2:38 ` Jakub Kicinski
2022-08-01 11:08 ` Kalle Valo [this message]
2022-07-30 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1w8mdbi.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ajay.kathat@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).