From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CD3C433F5 for ; Wed, 20 Oct 2021 16:16:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C24DE6139F for ; Wed, 20 Oct 2021 16:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbhJTQSp (ORCPT ); Wed, 20 Oct 2021 12:18:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46326 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231404AbhJTQSn (ORCPT ); Wed, 20 Oct 2021 12:18:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634746587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DB6FNE9518vrXKyk9/xmjFbyTClEQdA5fjKA0BXqbOU=; b=C1CxplX+wt/w8FshGX7ip5w6BktS8aPOZvXtGGFO816fY2w0nsMVrI0myRuyQgDwkCJZzh 1ll3f0Jd4DWFGYGHvqVl8H6WS/4OOVRBPQBT7D+lqQuv8xu2cWMocJ7epERM1O3DnMds7g MBvlVMsa1XPOW/MDEn7nHOgSIDC5hdc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-317-rnD-gQqwMm6UqK4E2MSdYQ-1; Wed, 20 Oct 2021 12:16:26 -0400 X-MC-Unique: rnD-gQqwMm6UqK4E2MSdYQ-1 Received: by mail-ed1-f70.google.com with SMTP id e14-20020a056402088e00b003db6ebb9526so21410198edy.22 for ; Wed, 20 Oct 2021 09:16:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=DB6FNE9518vrXKyk9/xmjFbyTClEQdA5fjKA0BXqbOU=; b=qTOGXQxSdgMe20pk5RBbjYdPCtyZu9V/gTf3XzTebmgHhag27oTlIlcj8URGpXdzdf ySUp+brDwAUN5jcZOPu1B20uALDdgxDkhdoE+ntuFEBofHQpcF/bV75X7CunjJqTRel/ JKpwkBO5/sn3AFiVxI6O2VrLI1GR0slgRoA22uPBBax5nFzye4dGpBEYOLkvmr1MrKzk hgCi8rMvNMuK2a55AaufO/SMtJ5E/8jurDy3W3e1I8qu0VN0spVRywKtqv+bZSFmCF/b ITgXCpnRyfNzMpYXXzaC0DWw1Fo3ymVXiIsGkkH5+oUPPUVHGqSZXUTLftu51Qubps03 9SEg== X-Gm-Message-State: AOAM532JAtLylpuRIn2JYNsX9FCVHqFLJFKSBUX4zDpIszrjOJBPOBZg yGQVsh21D0MJ6T+WUz4aarlGAYnLXQI2dj/DUSWBt++fxeO9VJxDhZBAVSOzKVw+Yzsfj/ULA7T Pwz8xsOiBF8mluEtr X-Received: by 2002:a17:907:7752:: with SMTP id kx18mr347265ejc.276.1634746583009; Wed, 20 Oct 2021 09:16:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxyQmCf6ySfQkkio7kRxi2QylOtvh+NWOtFaKQ59KcVINsv7754SFz8ClvR/dwt/emOrfu5A== X-Received: by 2002:a17:907:7752:: with SMTP id kx18mr347035ejc.276.1634746580913; Wed, 20 Oct 2021 09:16:20 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id i10sm1474006edl.15.2021.10.20.09.16.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 09:16:20 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 9D47A180262; Wed, 20 Oct 2021 18:16:19 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Lorenz Bauer , Maxim Mikityanskiy Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Eric Dumazet , "David S. Miller" , Jakub Kicinski , Hideaki YOSHIFUJI , David Ahern , Jesper Dangaard Brouer , Nathan Chancellor , Nick Desaulniers , Brendan Jackman , Florent Revest , Joe Stringer , Tariq Toukan , Networking , bpf , clang-built-linux@googlegroups.com Subject: Re: [PATCH bpf-next 09/10] bpf: Add a helper to issue timestamp cookies in XDP In-Reply-To: References: <20211019144655.3483197-1-maximmi@nvidia.com> <20211019144655.3483197-10-maximmi@nvidia.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 20 Oct 2021 18:16:19 +0200 Message-ID: <87y26nekoc.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Lorenz Bauer writes: >> +bool cookie_init_timestamp_raw(struct tcphdr *th, __be32 *tsval, __be32 *tsecr) > > I'm probably missing context, Is there something in this function that > means you can't implement it in BPF? I was about to reply with some other comments but upon closer inspection I ended up at the same conclusion: this helper doesn't seem to be needed at all? -Toke