From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435A2C4332E for ; Tue, 12 Jan 2021 15:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE5B123132 for ; Tue, 12 Jan 2021 15:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405739AbhALPsJ (ORCPT ); Tue, 12 Jan 2021 10:48:09 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:59291 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404932AbhALPsI (ORCPT ); Tue, 12 Jan 2021 10:48:08 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1610466469; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=Npsm5bOJjjcIuADdoI2VTocPa/2BU7I+DV9Z9yFCxjA=; b=lqg7NvuShMEOhrnwlERdqBrQ8MWAVrgesbFxyUVos5De+lD0X+kImbBcRV7n/6ajarvU0Ooq sAuu9Jar5RHBln45j/ktK1g2sV3m3irJm8EYmdnPGUJK/i0/wdfmV7hfNXOa15ZtGKQkzro+ hs3Y+jMgzCFZKhLIug8J6/qKfGc= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5ffdc4858fb3cda82feebb07 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 12 Jan 2021 15:47:17 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 39015C43462; Tue, 12 Jan 2021 15:47:17 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C4861C433CA; Tue, 12 Jan 2021 15:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C4861C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pkshih Cc: "abaci-bugfix\@linux.alibaba.com" , "linux-wireless\@vger.kernel.org" , "davem\@davemloft.net" , "linux-kernel\@vger.kernel.org" , "kuba\@kernel.org" , "netdev\@vger.kernel.org" Subject: Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison References: <1610440409-73330-1-git-send-email-abaci-bugfix@linux.alibaba.com> <1610457587.2793.2.camel@realtek.com> Date: Tue, 12 Jan 2021 17:47:12 +0200 In-Reply-To: <1610457587.2793.2.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 12 Jan 2021 13:20:21 +0000") Message-ID: <87y2gyrwcf.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Pkshih writes: > On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote: >> Fix the following coccicheck warning: >> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: >> WARNING: Comparison of 0/1 to bool variable >> >> Reported-by: Abaci Robot >> Signed-off-by: YANG LI >> > > I think your name of Signed-off-by should be "Yang Li". > > And, the subject prefix "rtlwifi: " is preferred. I can fix those during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches