* [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison
@ 2021-01-12 8:33 YANG LI
2021-01-12 13:20 ` Pkshih
2021-01-25 14:30 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: YANG LI @ 2021-01-12 8:33 UTC (permalink / raw)
To: pkshih; +Cc: kvalo, davem, kuba, linux-wireless, netdev, linux-kernel, YANG LI
Fix the following coccicheck warning:
./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
WARNING: Comparison of 0/1 to bool variable
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 372d6f8..1fb857c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -3848,7 +3848,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
else
rtl_write_dword(rtlpriv, 0xc8c, 0x00163e96);
- if (vdf_enable == 1) {
+ if (vdf_enable) {
rtl_dbg(rtlpriv, COMP_IQK, DBG_LOUD, "VDF_enable\n");
for (k = 0; k <= 2; k++) {
switch (k) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison
2021-01-12 8:33 [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison YANG LI
@ 2021-01-12 13:20 ` Pkshih
2021-01-12 15:47 ` Kalle Valo
2021-01-25 14:30 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Pkshih @ 2021-01-12 13:20 UTC (permalink / raw)
To: abaci-bugfix@linux.alibaba.com
Cc: linux-wireless@vger.kernel.org, kvalo@codeaurora.org,
davem@davemloft.net, linux-kernel@vger.kernel.org,
kuba@kernel.org, netdev@vger.kernel.org
On Tue, 2021-01-12 at 16:33 +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
>
I think your name of Signed-off-by should be "Yang Li".
And, the subject prefix "rtlwifi: " is preferred.
---
Ping-Ke
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison
2021-01-12 8:33 [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison YANG LI
2021-01-12 13:20 ` Pkshih
@ 2021-01-25 14:30 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-01-25 14:30 UTC (permalink / raw)
To: YANG LI; +Cc: pkshih, davem, kuba, linux-wireless, netdev, linux-kernel,
YANG LI
YANG LI <abaci-bugfix@linux.alibaba.com> wrote:
> Fix the following coccicheck warning:
> ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17:
> WARNING: Comparison of 0/1 to bool variable
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
Patchwork gives me this From field:
From: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
I guess you are sharing the same email address with multiple persons? And patchwork stored the first person using that address?
I recommend using individual addresses for each person submitting patches. I
cannot apply this.
--
https://patchwork.kernel.org/project/linux-wireless/patch/1610440409-73330-1-git-send-email-abaci-bugfix@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-25 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-12 8:33 [PATCH] rtlwifi: rtl8821ae: style: Simplify bool comparison YANG LI
2021-01-12 13:20 ` Pkshih
2021-01-12 15:47 ` Kalle Valo
2021-01-25 14:30 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).