From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace
Date: Fri, 11 Sep 2020 13:01:33 +0200 [thread overview]
Message-ID: <87y2lga86q.fsf@toke.dk> (raw)
In-Reply-To: <CAEf4BzbY3zV-xYDBvCYztXOkn=MJwHxOVyAH7YRH8JH869qtDg@mail.gmail.com>
Andrii Nakryiko <andrii.nakryiko@gmail.com> writes:
> On Wed, Sep 9, 2020 at 8:38 AM Jiri Olsa <jolsa@kernel.org> wrote:
>>
>> Adding test that setup following program:
>>
>> SEC("classifier/test_pkt_md_access")
>> int test_pkt_md_access(struct __sk_buff *skb)
>>
>> with its extension:
>>
>> SEC("freplace/test_pkt_md_access")
>> int test_pkt_md_access_new(struct __sk_buff *skb)
>>
>> and tracing that extension with:
>>
>> SEC("fentry/test_pkt_md_access_new")
>> int BPF_PROG(fentry, struct sk_buff *skb)
>>
>> The test verifies that the tracing program can
>> dereference skb argument properly.
>>
>> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Just FYI, I included this same patch in my freplace series. I didn't
change anything in the version I just resent, but I'll work with Jiri
and get an updated version of this into the next version based on your
comments here... :)
-Toke
next prev parent reply other threads:[~2020-09-11 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 15:11 [PATCH bpf-next 1/2] bpf: Fix context type resolving for extension programs Jiri Olsa
2020-09-09 15:11 ` [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace Jiri Olsa
2020-09-10 22:34 ` Andrii Nakryiko
2020-09-11 11:01 ` Toke Høiland-Jørgensen [this message]
2020-09-11 13:02 ` Jiri Olsa
2020-09-09 15:54 ` [PATCH bpf-next 1/2] bpf: Fix context type resolving for extension programs Toke Høiland-Jørgensen
2020-09-09 18:58 ` Jiri Olsa
2020-09-10 9:49 ` Toke Høiland-Jørgensen
2020-09-10 18:00 ` Alexei Starovoitov
2020-09-11 10:52 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2lga86q.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=echaudro@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).