From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDA37314D08 for ; Tue, 4 Nov 2025 10:17:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762251479; cv=none; b=f+NqMap5lXW+XRYu5cKWdEX+t11qnLaQcU3S17+p4gUsU2xFMWhAzwrsoCr5Desdp0Zk7PoxwA7MJzV/71A4uOEg/3yMcUKjCYc88Jl8u6C4PDbXz0cMf9ZtG/FJRKSywFokAs+U0NkHRX9r7DQ1Y7z3gMzHADHBOlN6hvVIuTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762251479; c=relaxed/simple; bh=0U0kFLASix37zELIkWNxq8vUqzlq9j+qqfasMEzbtCU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=D2iuWo80VRvh9fDdS3lWDFhR0dj7f88O+xJ0mRIwpr37FNafxM2agDLj3geUYoZq3+y2zRvfsdfKiSVWxeMOnRBXs1w1d0wpQwG1vmUAkqPKNco6e6u0teoU8V2gU7K4BtK1qX/HxgtZBCaAvmzfYfkciHkr4Iddb0hoULCDUas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hi1trBDo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gLiA8PuM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hi1trBDo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gLiA8PuM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762251476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0U0kFLASix37zELIkWNxq8vUqzlq9j+qqfasMEzbtCU=; b=hi1trBDoy5dam4fsJj8r8H1IoDk9GljXWL4BaVbatMcvDE9SnaXrF40UNKTjiBdSxJgtp+ 9J3g+pFmDhsa4aPGHc0adtkRQPKqzBsxmiuTTr6vUYw03A2TSwhNTJR8ITuIIglf/NOUKl W52jaAayorpDKMWyheZHmgWeo6H+MQ8= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-6xfO47dJNKe61y8i4RMwEA-1; Tue, 04 Nov 2025 05:17:55 -0500 X-MC-Unique: 6xfO47dJNKe61y8i4RMwEA-1 X-Mimecast-MFC-AGG-ID: 6xfO47dJNKe61y8i4RMwEA_1762251474 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-640b06fa998so2127968a12.2 for ; Tue, 04 Nov 2025 02:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1762251474; x=1762856274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0U0kFLASix37zELIkWNxq8vUqzlq9j+qqfasMEzbtCU=; b=gLiA8PuMxVrWkfqY2PrsweTr0XtGDSjAT6BR1wv2jTXXo4E2PkWYRQUR2t4YMWkPsG zPORIOhDYAH+L06TS3C5n4cUYIxuscy8iFRQ+iZJo6VlcxwntsaTJu14JiQG3dyACnZs 1tx5v0Y+NtOUuYP/UUoYy1Kr+TJkwuZHei1ORynKlhtbyew19sE6g18DQ5PLOoPY6mgg 71iVic5rv4vKgH966I1sBOGIHXSXEwN/+5ZQbSS3zVsdf8876Uqg66AmQpnQdQ7yY+JZ IVPhq7eytJLag9IxG7FdgPbxVYyc3Sk2Y67qJ9wUhB6p/LT/TeNnQRHn4jQr1bkWRbXe sjWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762251474; x=1762856274; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0U0kFLASix37zELIkWNxq8vUqzlq9j+qqfasMEzbtCU=; b=RgWoAqXo27MOQvaYVHdLj00A4LLekLpcGsX8hnJzB5OlBqO6uGqxXIszxHi2hEUK6H VJJZqVDuBs6L2IHxj4U2K7+r4Be8dSbtDucFbbHnY0aXISJ15RU37sKmU+otG7kcT3k/ xcg+xLwhfbzjEB3rNHPeEfxX92NEkoch1267KA6S2dC3oVD3XpctnYZYkbGssLGqHdYt Ul6qr69ib7dceucO2vvkj9r1dDQwpa5coRzickVw9Lh642AqpMEhU6MTkOlLFu2fW8Fp oJ3F6qtWOg6wziv3KdF9hy8EBNULAJnoag90/ZwJbZEXTSf2nNHxy58mvJmazfMTkTht FzPA== X-Forwarded-Encrypted: i=1; AJvYcCULheVVNIH6W/Tzb7ollPYwM5u+NR01PHxx/kNpNle1QyTMVJFQUZtj+tf7k0+x7wit9gkK+bo=@vger.kernel.org X-Gm-Message-State: AOJu0YyCCG6ljWM+J/CuvMpeAb8IvAOtq/nat561JQlmTfvc4ZFRuy9N cdtCMDEttBiy9pRJuMoSTS9zBHaRt+yEEU0I/gNMtnfingJc13Fan5dOzilz5RVFeCVAuouZWNx k1H6j7gV2+4VMtxp66n+ZejKtAbZ/1Pb6rpBuRWe9n4+Y7e3NWpzr1YKH/A== X-Gm-Gg: ASbGnctcXtuWA7wSD5d1C+NqQuGkS1r+HVz2TX1/Ued7SNxJ/19kro3hgO67WCbzXSQ SE7cQRhAtG/i3Ih0rmN8CW1H+9Avm9h3N9SnAunpyjZ7Cuv1BkVExrFgSsCOOyNT218qhKfcBqL VPuedySyegycppc/WMGgczaSs5d7Herfh67d3CTze/NYOk+z5ZXzH1uJeU7Y78uaI8urzsjGg3f e2Kd1YaljY/rTJhwTDb4pA1YVxjKoVAtua3uhJCErakNTZFqRSwvZMiW+78YE7BsUGAr3gO8OKf YKtwHddLNTmPARjL+SRgamvokMGvAk2YVHIAZl3CcPrrvrA4ty7cKhxy5rFV3kOA+Fq0s39zfie piJ8xk8Xvsxr4hvo3vnVzkuQ= X-Received: by 2002:a05:6402:2708:b0:640:aefd:f47d with SMTP id 4fb4d7f45d1cf-640aefdf831mr7641269a12.21.1762251473925; Tue, 04 Nov 2025 02:17:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFu5k8o/2pT/Sl7v2zX531F5JVWTzROWk3FxKJqNgqco5tJVsMjiW9FXeSfP0WsuPN495V1kA== X-Received: by 2002:a05:6402:2708:b0:640:aefd:f47d with SMTP id 4fb4d7f45d1cf-640aefdf831mr7641243a12.21.1762251473568; Tue, 04 Nov 2025 02:17:53 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-640e67eb666sm1705024a12.3.2025.11.04.02.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Nov 2025 02:17:52 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 875F332860B; Tue, 04 Nov 2025 11:17:51 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Adrian Moreno , netdev@vger.kernel.org Cc: kuba@kernel.org, nicolas.dichtel@6wind.com, Adrian Moreno , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Stanislav Fomichev , Xiao Liang , Cong Wang , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3] rtnetlink: honor RTEXT_FILTER_SKIP_STATS in IFLA_STATS In-Reply-To: <20251103154006.1189707-1-amorenoz@redhat.com> References: <20251103154006.1189707-1-amorenoz@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 04 Nov 2025 11:17:51 +0100 Message-ID: <87zf92nltc.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Adrian Moreno writes: > Gathering interface statistics can be a relatively expensive operation > on certain systems as it requires iterating over all the cpus. > > RTEXT_FILTER_SKIP_STATS was first introduced [1] to skip AF_INET6 > statistics from interface dumps and it was then extended [2] to > also exclude IFLA_VF_INFO. > > The semantics of the flag does not seem to be limited to AF_INET > or VF statistics and having a way to query the interface status > (e.g: carrier, address) without retrieving its statistics seems > reasonable. So this patch extends the use RTEXT_FILTER_SKIP_STATS > to also affect IFLA_STATS. > > [1] https://lore.kernel.org/all/20150911204848.GC9687@oracle.com/ > [2] https://lore.kernel.org/all/20230611105108.122586-1-gal@nvidia.com/ > > Signed-off-by: Adrian Moreno Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen