netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Paolo Abeni <pabeni@redhat.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>,
	Jiri Pirko <jiri@resnulli.us>
Cc: Ilya Maximets <i.maximets@redhat.com>,
	Frode Nordahl <frode.nordahl@canonical.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] tc: Ensure we have enough buffer space when sending filter netlink notifications
Date: Tue, 08 Apr 2025 14:59:50 +0200	[thread overview]
Message-ID: <87zfgqvmex.fsf@toke.dk> (raw)
In-Reply-To: <126fa7e1-dbe0-48ff-9cb5-31c1d4dea964@redhat.com>

Paolo Abeni <pabeni@redhat.com> writes:

> On 4/7/25 12:55 PM, Toke Høiland-Jørgensen wrote:
>> To trigger this, run the following commands:
>> 
>>  # ip link add type veth
>>  # tc qdisc replace dev veth0 root handle 1: fq_codel
>>  # tc -echo filter add dev veth0 parent 1: u32 match u32 0 0 $(for i in $(seq 32); do echo action pedit munge ip dport set 22; done)
>> 
>> Before this fix, tc just returns:
>> 
>> Not a filter(cmd 2)
>> 
>> After the fix, we get the correct echo:
>> 
>> added filter dev veth0 parent 1: protocol all pref 49152 u32 chain 0 fh 800::800 order 2048 key ht 800 bkt 0 terminal flowid not_in_hw
>>   match 00000000/00000000 at 0
>> 	action order 1:  pedit action pass keys 1
>>  	index 1 ref 1 bind 1
>> 	key #0  at 20: val 00000016 mask ffff0000
>> [repeated 32 times]
>
> I think it would be great if you could follow-up capturing the above in
> a self-test.

Sure, can do!

-Toke


  reply	other threads:[~2025-04-08 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 10:55 [PATCH net] tc: Ensure we have enough buffer space when sending filter netlink notifications Toke Høiland-Jørgensen
2025-04-07 11:12 ` Jiri Pirko
2025-04-08 11:57 ` Paolo Abeni
2025-04-08 12:59   ` Toke Høiland-Jørgensen [this message]
2025-04-08 12:10 ` patchwork-bot+netdevbpf
2025-04-09 17:36 ` Cong Wang
2025-04-10 10:28   ` Toke Høiland-Jørgensen
2025-04-14 21:00     ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zfgqvmex.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=frode.nordahl@canonical.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@redhat.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).