From: Kalle Valo <kvalo@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: "Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Amitkumar Karwar" <amitkarwar@gmail.com>,
"Ganapathi Bhat" <ganapathi017@gmail.com>,
"Sharvari Harisangam" <sharvari.harisangam@nxp.com>,
"Xinming Hu" <huxinming820@gmail.com>,
linux-wireless@vger.kernel.org,
"Andrejs Cainikovs" <andrejs.cainikovs@toradex.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
netdev@vger.kernel.org, "Jonas Dreßler" <verdre@v0yd.nl>
Subject: Re: [RFC PATCH] mwifiex: Select firmware based on strapping
Date: Wed, 23 Mar 2022 09:31:32 +0200 [thread overview]
Message-ID: <87zglhktuz.fsf@kernel.org> (raw)
In-Reply-To: <Yjjgi4YJVYBnJTqK@google.com> (Brian Norris's message of "Mon, 21 Mar 2022 13:31:07 -0700")
Brian Norris <briannorris@chromium.org> writes:
>> --- a/drivers/net/wireless/marvell/mwifiex/sdio.h
>> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.h
>> @@ -39,6 +39,7 @@
>> #define SD8977_DEFAULT_FW_NAME "mrvl/sdsd8977_combo_v2.bin"
>> #define SD8987_DEFAULT_FW_NAME "mrvl/sd8987_uapsta.bin"
>> #define SD8997_DEFAULT_FW_NAME "mrvl/sdsd8997_combo_v4.bin"
>> +#define SD8997_SDIOUART_FW_NAME "nxp/sdiouart8997_combo_v4.bin"
>
> This isn't your main issue, but just because companies buy and sell IP
> doesn't mean we'll change the firmware paths. Qualcomm drivers still use
> "ath" prefixes, for one ;)
>
> Personally, I'd still keep the mrvl/ path. But that might be up to Kalle
> and/or linux-firmware.git maintainers.
I also prefer to have all the firmware files in the mrvl directory.
Actually I would prefer that each driver has it's own firmware
directory, but that's another topic.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-03-23 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 16:10 [RFC PATCH] mwifiex: Select firmware based on strapping Francesco Dolcini
2022-03-21 20:31 ` Brian Norris
2022-03-23 7:31 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zglhktuz.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=amitkarwar@gmail.com \
--cc=andrejs.cainikovs@toradex.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=francesco.dolcini@toradex.com \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sharvari.harisangam@nxp.com \
--cc=verdre@v0yd.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).