From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B787C4361B for ; Fri, 18 Dec 2020 08:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FA0623A23 for ; Fri, 18 Dec 2020 08:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733098AbgLRIuT (ORCPT ); Fri, 18 Dec 2020 03:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728216AbgLRIuS (ORCPT ); Fri, 18 Dec 2020 03:50:18 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDEBC0617A7 for ; Fri, 18 Dec 2020 00:49:38 -0800 (PST) From: Kurt Kanzenbach DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1608281376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMy1ZdkxXI6XtsVIVHrVwJuv/xQ+6BzEq6pv4KMMMBQ=; b=LUWyBLwXFweBYBmP6FjZjDX7u+VdoitTFlvp6D3K/ddrDNdT483S3rHjnCqW2N6El+o3GT d9Zvu9NZkAUqmYojd6+Lkqg0WY3IdDvNOtBVWvxmNdjNsjquCGDHKeDkMuoSpDRBDtPwvl XPXbwoXZijQZNrKmckO3RGhXcuFJtO/GVsEtGCrFqVdjYRs3lWFLPSPmLZDEXthH8hdUp/ TiTbIpJnfClB7OJVa3vZmQYIgNlXYCtGWmMRhXpyR9GTinMqtkGD2zzIjodkYAb8wnsBjC ges5gc29MPVV91BuWAuYTyJmrqHHNVQpAfoAskcocwhdKqKQMRKtG1cPZn9JtA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1608281376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pMy1ZdkxXI6XtsVIVHrVwJuv/xQ+6BzEq6pv4KMMMBQ=; b=eWIFJCpGO0KhDSZhTlYaC8kTnTzXeHbwcyhm/2T5j2kDVsT7kZ9fqPi1z/Kext54njmRaI PqwN6ATT8/AwSPBg== To: Vladimir Oltean , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org Cc: Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Hauke Mehrtens , Woojung Huh , Microchip Linux Driver Support , Sean Wang , Landen Chao , Claudiu Manoil , Alexandre Belloni , Linus Walleij , Vadym Kochan , Taras Chornyi , Jiri Pirko , Ido Schimmel , Grygorii Strashko , Ioana Ciornei , Ivan Vecera Subject: Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects In-Reply-To: <20201217015822.826304-7-vladimir.oltean@nxp.com> References: <20201217015822.826304-1-vladimir.oltean@nxp.com> <20201217015822.826304-7-vladimir.oltean@nxp.com> Date: Fri, 18 Dec 2020 09:49:31 +0100 Message-ID: <87zh2b1otg.fsf@kurt> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --=-=-= Content-Type: text/plain Hi Vladimir, On Thu Dec 17 2020, Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to propagate > errors directly from the .port_vlan_add callback. > > Signed-off-by: Vladimir Oltean Reviewed-by: Kurt Kanzenbach for the hellcreek part. Thanks, Kurt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEooWgvezyxHPhdEojeSpbgcuY8KYFAl/cbRsACgkQeSpbgcuY 8KZ0UA//ST/+HOjOljHsK3EGkwGV1dHgMi6j5Z2zwMQ1rlNCEFdbZoin0awrbcjq XUyuwBMZ8oBwsrWBtAt3NeL6/ypRr5B+J8uboAGcXYRFt2NU52+J6dmFV7VqRDS1 IaW7wuDyfEeQcjkJcsfxC+JMKWSq/KFSGIZ7VB8OVQch5yY2UNeh3IEidRGip5iQ NPUWPnF+4UKJ9Bpf9BNIHgL5xGt9AXIq+fQ/9y/TPyyx9S9akYrcfw/v78Xhkajg 48Y4WowjsrtiIf9BCI/q7LQWDY+w7vvHRML8xTs5Xs87FJYUaxQk2jX5KnPdOAZ/ TEeLBzTXW5FFscc+qfguRp8UHUTVv5lyhbb/q5/o3FFILvhLQlpT/+6q+hTQk0VI +MzIMDc3P93JqqHONPqGje8oWuzqg7fOD0hvdezemN//TI3AJ+2gax2YD58VTKWA TPVY/j6dUOzFfPgNh1h7B7FwG9tXIsun/v6paQGgNc9TfTg41G5HW8gNmzjLERL4 gRtKMWRZIdSTvkK4WvxrJ/1GZn+RdejgJHOhnHrmUxjGprGvm1srvf9N6QIc/O/c Jv3gw5C/u4vOFsU0Gw7BF7i2xD9sS1Ty2EyahC7Iw3aZk6iVsAzY3OvymPAxmQE+ Vm4zRs6GzPOvmD15VG02wgWDQpYtsfMtD+lkEz4SgQIELylqvCY= =C4vK -----END PGP SIGNATURE----- --=-=-=--