From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: daniel@iogearbox.net, ast@fb.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, Alan Maguire <alan.maguire@oracle.com>
Subject: Re: [PATCH bpf-next] selftests/bpf_iter: don't fail test due to missing __builtin_btf_type_id
Date: Tue, 29 Sep 2020 14:50:02 +0200 [thread overview]
Message-ID: <87zh5821dx.fsf@toke.dk> (raw)
In-Reply-To: <alpine.LRH.2.21.2009291333310.26076@localhost>
Alan Maguire <alan.maguire@oracle.com> writes:
> On Tue, 29 Sep 2020, Toke Høiland-Jørgensen wrote:
>
>> The new test for task iteration in bpf_iter checks (in do_btf_read()) if it
>> should be skipped due to missing __builtin_btf_type_id. However, this
>> 'skip' verdict is not propagated to the caller, so the parent test will
>> still fail. Fix this by also skipping the rest of the parent test if the
>> skip condition was reached.
>>
>> Fixes: b72091bd4ee4 ("selftests/bpf: Add test for bpf_seq_printf_btf helper")
>> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> Reviewed-by: Alan Maguire <alan.maguire@oracle.com>
>
> Thanks for fixing this Toke!
You're welcome! :)
-Toke
prev parent reply other threads:[~2020-09-29 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:30 [PATCH bpf-next] selftests/bpf_iter: don't fail test due to missing __builtin_btf_type_id Toke Høiland-Jørgensen
2020-09-29 12:35 ` Alan Maguire
2020-09-29 12:50 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh5821dx.fsf@toke.dk \
--to=toke@redhat.com \
--cc=alan.maguire@oracle.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).