From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: David Ahern <dsahern@kernel.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org,
prashantbhole.linux@gmail.com, jasowang@redhat.com,
brouer@redhat.com, toshiaki.makita1@gmail.com,
daniel@iogearbox.net, john.fastabend@gmail.com, ast@kernel.org,
kafai@fb.com, songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
dsahern@gmail.com
Subject: Re: [PATCH v3 bpf-next 00/15] net: Add support for XDP in egress path
Date: Mon, 27 Apr 2020 17:21:24 +0200 [thread overview]
Message-ID: <87zhaxx8cr.fsf@toke.dk> (raw)
In-Reply-To: <20200424201428.89514-1-dsahern@kernel.org>
David Ahern <dsahern@kernel.org> writes:
> From: David Ahern <dsahern@gmail.com>
>
> This series adds support for XDP in the egress path by introducing
> a new XDP attachment type, BPF_XDP_EGRESS
Can't find anything more to complain about :)
Ran a quick performance test: On a test using xdp_redirect_map from
samples/bpf, which gets 8.15 Mpps normally, loading an XDP egress
program on the target interface drops performance to 7.55 Mpps. So ~600k
pps, or ~9.5ns overhead for the egress program. So other than the nit in
the bpftool patch, please consider the series:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2020-04-27 15:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 20:14 [PATCH v3 bpf-next 00/15] net: Add support for XDP in egress path David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 01/15] net: Refactor convert_to_xdp_frame David Ahern
2020-04-27 16:19 ` John Fastabend
2020-04-24 20:14 ` [PATCH v3 bpf-next 02/15] net: uapi for XDP programs in the egress path David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 03/15] net: Add XDP setup and query commands for Tx programs David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 04/15] net: Add BPF_XDP_EGRESS as a bpf_attach_type David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 05/15] xdp: Add xdp_txq_info to xdp_buff David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 06/15] net: Rename do_xdp_generic to do_xdp_generic_rx David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 07/15] net: rename netif_receive_generic_xdp to do_generic_xdp_core David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 08/15] net: set XDP egress program on netdevice David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 09/15] net: Support xdp in the Tx path for packets as an skb David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 10/15] net: Support xdp in the Tx path for xdp_frames David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 11/15] libbpf: Add egress XDP support David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 12/15] bpftool: Add support for XDP egress David Ahern
2020-04-27 15:13 ` Toke Høiland-Jørgensen
2020-04-24 20:14 ` [PATCH v3 bpf-next 13/15] selftest: Add test for xdp_egress David Ahern
2020-04-27 17:48 ` John Fastabend
2020-04-27 17:52 ` John Fastabend
2020-04-27 17:58 ` David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 14/15] selftest: Add xdp_egress attach tests David Ahern
2020-04-24 20:14 ` [PATCH v3 bpf-next 15/15] samples/bpf: add XDP egress support to xdp1 David Ahern
2020-04-27 15:21 ` Toke Høiland-Jørgensen [this message]
2020-04-27 18:25 ` [PATCH v3 bpf-next 00/15] net: Add support for XDP in egress path John Fastabend
2020-04-27 18:58 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhaxx8cr.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prashantbhole.linux@gmail.com \
--cc=songliubraving@fb.com \
--cc=toshiaki.makita1@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).