From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6EAAC33CB3 for ; Tue, 28 Jan 2020 10:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8DCD224688 for ; Tue, 28 Jan 2020 10:28:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=unikie-com.20150623.gappssmtp.com header.i=@unikie-com.20150623.gappssmtp.com header.b="priCxcB8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726073AbgA1K2T (ORCPT ); Tue, 28 Jan 2020 05:28:19 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41945 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725926AbgA1K2T (ORCPT ); Tue, 28 Jan 2020 05:28:19 -0500 Received: by mail-lj1-f194.google.com with SMTP id h23so14127313ljc.8 for ; Tue, 28 Jan 2020 02:28:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unikie-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=R/hB3d9WV1ZfOuGwum6uaHEPLLo7pAkJ9wkfhb8ryno=; b=priCxcB8LwrgDL3P9hJ8Fhmz7cxKGIy5qUbauEytJmHyUWYu7pXT5HSujg53hLD3Lr krD7ENJZwPzwkJrsrHAK6YqYhHgULLtAv3mK/hHiODmlK32heqyLinOp00IRwaIuXApL r2IK4w3Ajxik/4eEu8URX3EjVRQlMxzkY/UpVyhmwgZAszAKja9SosTyp8ojYQMuoUn0 cSNpivomMSRy5LkkEMTLTVtyJgXrq68NQ6QCCrfix2uFvQ4B4DMTtx0XOoo6Fk0Q4F37 Yc6wsBtUuRXwz3SS71tWgFCnxW+4bCcSWOKSvBjtE13pMU9IvLjbV3IrIpat5Uq1UorZ 0E6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=R/hB3d9WV1ZfOuGwum6uaHEPLLo7pAkJ9wkfhb8ryno=; b=pwP2CJxVQFEpCnSUc8Sv0DApPvD6BpeGgZ4aNc1R+EkmslziAMd1PmcaapI6UgniJe mIKcDp6AFzvC+qSSDpFSxMxqNHFsOI2jRIzrk/eTbblHHN6N6MhO3XZZyyNS0p4RhE7W yS6ItTTqOS01pusBUUZYbiLpwylp65fjoiPB2SowZqOdTCIMCeLuiFhFsmBy5DrUOuv9 HnOdP0HgGKCBQL56gFAAPgkt8p0sNGPOi0osCmiIU58UWVcqSkFmcI3m2pGxEc1+HdjT 3yOWccaM7He0NrE1yJZF0LkaDg9QtUKh3FYAGhwR1fTsdfKQXMUTxWKEqDcS3PC4Nk/5 pn8Q== X-Gm-Message-State: APjAAAWw+xDtIfazo4W+Uc1iCUZVJmo7ITIvQ9NH0juueN/KGp7mugzr BQ/GB5ytFpLjSHyauhyz9BpMvA== X-Google-Smtp-Source: APXvYqz1H+G5sAa2YK3jJrrb2gl81iOk9gR7ql0r3PFxcDlQk+/3WQL3GKFf6/h+4lgSCFz2FboK2w== X-Received: by 2002:a2e:9c04:: with SMTP id s4mr13050425lji.147.1580207297152; Tue, 28 Jan 2020 02:28:17 -0800 (PST) Received: from GL-434 ([109.204.235.119]) by smtp.gmail.com with ESMTPSA id d11sm9687741lfj.3.2020.01.28.02.28.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Jan 2020 02:28:16 -0800 (PST) From: jouni.hogander@unikie.com (Jouni =?utf-8?Q?H=C3=B6gander?=) To: Greg Kroah-Hartman Cc: Lukas Bulwahn , Greg Kroah-Hartman , open list , Andrew Morton , Ben Hutchings , linux- stable , Netdev , Al Viro , linux-fsdevel@vger.kernel.org, Eric Dumazet , "David S. Miller" , syzkaller@googlegroups.com Subject: Re: [PATCH 4.19 000/306] 4.19.87-stable review References: <20191127203114.766709977@linuxfoundation.org> <20191128073623.GE3317872@kroah.com> <20191129085800.GF3584430@kroah.com> <87sgk8szhc.fsf@unikie.com> Date: Tue, 28 Jan 2020 12:28:15 +0200 In-Reply-To: <87sgk8szhc.fsf@unikie.com> ("Jouni \=\?utf-8\?Q\?H\=C3\=B6gander\?\= \=\?utf-8\?Q\?\=22's\?\= message of "Wed, 22 Jan 2020 09:48:47 +0200") Message-ID: <87zhe727uo.fsf@unikie.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello Greg, jouni.hogander@unikie.com (Jouni H=C3=B6gander) writes: > Greg Kroah-Hartman writes: >>> > Now queued up, I'll push out -rc2 versions with this fix. >>> > >>> > greg k-h >>>=20 >>> We have also been informed about another regression these two commits >>> are causing: >>>=20 >>> https://lore.kernel.org/lkml/ace19af4-7cae-babd-bac5-cd3505dcd874@I-lov= e.SAKURA.ne.jp/ >>>=20 >>> I suggest to drop these two patches from this queue, and give us a >>> week to shake out the regressions of the change, and once ready, we >>> can include the complete set of fixes to stable (probably in a week or >>> two). >> >> Ok, thanks for the information, I've now dropped them from all of the >> queues that had them in them. >> >> greg k-h > > I have now run more extensive Syzkaller testing on following patches: > > cb626bf566eb net-sysfs: Fix reference count leak > ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject > e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje > 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage > b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_k= object > > These patches are fixing couple of memory leaks including this one found > by Syzbot: https://syzkaller.appspot.com/bug?extid=3Dad8ca40ecd77896d51e2 > > I can reproduce these memory leaks in following stable branches: 4.14, > 4.19, and 5.4. > > These are all now merged into net/master tree and based on my testing > they are ready to be taken into stable branches as well. > > Best Regards, > > Jouni H=C3=B6gander These four patches are still missing from 4.14 and 4.19 branches: ddd9b5e3e765 net-sysfs: Call dev_hold always in rx_queue_add_kobject e0b60903b434 net-sysfs: Call dev_hold always in netdev_queue_add_kobje 48a322b6f996 net-sysfs: fix netdev_queue_add_kobject() breakage b8eb718348b8 net-sysfs: Fix reference count leak in rx|netdev_queue_add_kob= ject Could you please consider taking them in or let me know if you want some further activities from my side? BR, Jouni H=C3=B6gander