From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "yuehaibing\@huawei.com" <yuehaibing@huawei.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'
Date: Wed, 30 Jan 2019 12:47:49 +0200 [thread overview]
Message-ID: <87zhrijuay.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1548811903.17195.1.camel@realtek.com> (pkshih@realtek.com's message of "Wed, 30 Jan 2019 01:31:54 +0000")
Pkshih <pkshih@realtek.com> writes:
> On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
>> +cc netdev@vger.kernel.org
>>
>> On 2019/1/29 13:57, YueHaibing wrote:
>> > ping...
>> >
>> > On 2018/9/11 20:12, YueHaibing wrote:
>> >> Fixes gcc '-Wunused-but-set-variable' warning:
>> >>
>> >> drivers/net/wireless/realtek/rtlwifi/base.c: In function
>> 'rtl_c2h_content_parsing':
>> >> drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
>> >> variable 'cmd_seq' set but not used [-Wunused-but-set-variable]
>> >>
>> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Thanks for your fix.
>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
For some reason I couldn't find the original patch from patchwork.
I didn't find the version sent today though:
https://patchwork.kernel.org/patch/10787619/
BTW YueHaibing, you can check the linux-wireless patch status yourself from
the patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
--
Kalle Valo
next prev parent reply other threads:[~2019-01-30 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1536667978-10556-1-git-send-email-yuehaibing@huawei.com>
[not found] ` <581817ea-a414-e6ed-3615-5e44837a5221@huawei.com>
2019-01-29 6:03 ` [PATCH] rtlwifi: remove set but not used variable 'cmd_seq' YueHaibing
2019-01-30 1:31 ` Pkshih
2019-01-30 10:47 ` Kalle Valo [this message]
2019-01-31 1:53 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhrijuay.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).