From: "Bjørn Mork" <bjorn@mork.no>
To: "Jörgen Storvist" <jorgen.storvist@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] qmi_wwan: Added support for Fibocom NL668 series
Date: Mon, 10 Dec 2018 14:52:35 +0100 [thread overview]
Message-ID: <87zhtdsd3w.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20181209235726.00006bcc@gmail.com> ("Jörgen Storvist"'s message of "Sun, 9 Dec 2018 23:57:26 +0100")
Jörgen Storvist <jorgen.storvist@gmail.com> writes:
> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17.
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
>
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..820081e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1263,6 +1263,7 @@ static const struct usb_device_id products[] = {
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0121, 4)}, /* Quectel EC21 Mini PCIe */
> {QMI_QUIRK_SET_DTR(0x2c7c, 0x0191, 4)}, /* Quectel EG91 */
> {QMI_FIXED_INTF(0x2c7c, 0x0296, 4)}, /* Quectel BG96 */
> + {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series */
>
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
Looks good, but could you please try to add it in a semi-numeric order?
Yes, I know it's far from perfect from before. But I'm hoping to avoid
it growing worse ;-)
Bjørn
next prev parent reply other threads:[~2018-12-10 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 22:57 [PATCH] qmi_wwan: Added support for Fibocom NL668 series Jörgen Storvist
2018-12-10 13:52 ` Bjørn Mork [this message]
2018-12-11 13:49 ` [PATCH v2] " Jörgen Storvist
2018-12-11 14:12 ` Bjørn Mork
2018-12-11 15:49 ` [PATCH v3] " Jörgen Storvist
2018-12-11 20:56 ` Bjørn Mork
-- strict thread matches above, loose matches on Subject: below --
2018-12-09 15:35 [PATCH] " Jörgen Storvist
2018-12-09 19:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhtdsd3w.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=jorgen.storvist@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).