From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH net-next v5] Add Common Applications Kept Enhanced (cake) qdisc
Date: Sat, 28 Apr 2018 18:05:37 +0200
Message-ID: <87zi1n2u5q.fsf@toke.dk>
References: <20180427193901.8057-1-toke@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: cake@lists.bufferbloat.net, Dave Taht <dave.taht@gmail.com>
To: netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:48891 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1757745AbeD1QFk (ORCPT <rfc822;netdev@vger.kernel.org>);
        Sat, 28 Apr 2018 12:05:40 -0400
In-Reply-To: <20180427193901.8057-1-toke@toke.dk>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk> writes:

> +static inline struct tcphdr *cake_get_tcphdr(struct sk_buff *skb)
> +{
> +	struct ipv6hdr *ipv6h;
> +	struct iphdr *iph;
> +	struct tcphdr *th;
> +
> +
> +	switch (skb->protocol) {
> +	case cpu_to_be16(ETH_P_IP):

As someone was kind enough to point out off-list, skb->protocol doesn't
actually contain the protocol number of the inner protocol, so this
doesn't work for 6in4 encapsulation. Will try again...

-Toke