From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: qca_merez <qca_merez@qca.qualcomm.com>,
QCA_ailizaro <QCA_ailizaro@QCA.qualcomm.com>,
qca_dlansky <qca_dlansky@qca.qualcomm.com>,
QCA_hkadmany <QCA_hkadmany@QCA.qualcomm.com>,
qca_liord <qca_liord@qca.qualcomm.com>,
QCA_gidons <QCA_gidons@qca.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
wil6210 <wil6210@qca.qualcomm.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wil6210: fix build warnings without CONFIG_PM
Date: Mon, 18 Dec 2017 14:36:37 +0000 [thread overview]
Message-ID: <87zi6gje6j.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20171218134604.3087909-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Dec 2017 14:45:51 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> The #ifdef checks are hard to get right, in this case some functions
> should have been left inside a CONFIG_PM_SLEEP check as seen by this
> message:
>
> drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_resume' defined but not used [-Werror=unused-function]
> drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_suspend' defined but not used [-Werror=unused-function]
>
> Using an __maybe_unused is easier here, so I'm replacing all the
> other #ifdef in this file as well for consistency.
>
> Fixes: 94162666cd51 ("wil6210: run-time PM when interface down")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
A note to myself (unfortunately patchwork doesn't have any way to add
notes to patches): 94162666cd51 is in wireless-drivers-next so this
patch should also go to -next.
--
Kalle Valo
next prev parent reply other threads:[~2017-12-18 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 13:45 [PATCH] wil6210: fix build warnings without CONFIG_PM Arnd Bergmann
2017-12-18 14:36 ` Kalle Valo [this message]
2017-12-27 10:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi6gje6j.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=QCA_ailizaro@QCA.qualcomm.com \
--cc=QCA_gidons@qca.qualcomm.com \
--cc=QCA_hkadmany@QCA.qualcomm.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qca_dlansky@qca.qualcomm.com \
--cc=qca_liord@qca.qualcomm.com \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox