From: Kalle Valo <kvalo@codeaurora.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: amitkarwar@gmail.com, nishants@marvell.com, gbhat@marvell.com,
huxm@marvell.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mwifiex: Use put_unaligned_le32
Date: Thu, 05 Oct 2017 11:41:38 +0300 [thread overview]
Message-ID: <87zi963s1p.fsf@codeaurora.org> (raw)
In-Reply-To: <20171005083433.GA11485@himanshu-Vostro-3559> (Himanshu Jha's message of "Thu, 5 Oct 2017 14:04:33 +0530")
Himanshu Jha <himanshujha199640@gmail.com> writes:
>> > --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c
>> > +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c
>> > @@ -17,6 +17,7 @@
>> > * this warranty disclaimer.
>> > */
>> >
>> > +#include <linux/unaligned/access_ok.h>
>>
>> I don't think this is correct. Should it be asm/unaligned.h?
>
> Would mind explainig me as to why it is incorrect! Also, it defined in
> both the header files but, why is asm/unaligned.h preferred ?
asm/unaligned.h seems to be the toplevel header file which includes
header files based on arch configuration. Also grepping the sources
support that, nobody from drivers/ include access_ok.h directly.
But I can't say that I fully understand how the header files work so
please do correct me if I have mistaken.
--
Kalle Valo
next prev parent reply other threads:[~2017-10-05 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 18:28 [PATCH] mwifiex: Use put_unaligned_le32 Himanshu Jha
2017-10-05 7:23 ` Kalle Valo
2017-10-05 8:34 ` Himanshu Jha
2017-10-05 8:41 ` Kalle Valo [this message]
2017-10-05 15:22 ` Himanshu Jha
2017-10-05 18:02 ` Brian Norris
2017-10-05 19:07 ` Himanshu Jha
2017-10-05 21:54 ` Igor Mitsyanko
2017-10-06 13:31 ` Kalle Valo
2017-10-07 3:31 ` kbuild test robot
2017-10-07 5:17 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi963s1p.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=gbhat@marvell.com \
--cc=himanshujha199640@gmail.com \
--cc=huxm@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).