From: arno@natisbad.org (Arnaud Ebalard)
To: Patrick McHardy <kaber@trash.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.
Date: Tue, 29 Apr 2008 01:07:57 +0200 [thread overview]
Message-ID: <87zlrdtw6q.fsf@natisbad.org> (raw)
In-Reply-To: <481647F2.20507@trash.net> (Patrick McHardy's message of "Mon, 28 Apr 2008 23:56:02 +0200")
Hi,
Patrick McHardy <kaber@trash.net> writes:
> Good catch, thanks. That code seems to be very resistent against
> attempts to fix it :)
>
> Patch applied, and I'll also send it to -stable once it hits
> upstream.
Ack.
BTW, while looking at the code, I noticed the call to skb_copy_expand()
leads to a complete copy of current sk_buff data to the new sk_buff.
Those data are then completely rewritten a few lines later. Too bad
there is no simple way (considering skbuff.h) to prevent the useless
copy.
Cheers,
a+
next prev parent reply other threads:[~2008-04-28 23:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:49 [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet Arnaud Ebalard
2008-04-28 21:56 ` Patrick McHardy
2008-04-28 23:07 ` Arnaud Ebalard [this message]
2008-05-06 10:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zlrdtw6q.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).