From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB4022D238A; Wed, 22 Apr 2026 17:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776877420; cv=none; b=Lzh0N89C4Lkc9EuJ1i9SyrK1UNVZs4389TDbcenu2UqIwQshx8sH20FxqNC3TSnHxI4ujUWlCMrJr7eCqgUZR+k/HoCH81OGHCeSR4426WZJGkIA8KyZ6qqhmflBzz03rB7BktkBX3qSXZa6vNNaaUsr94OaNlTIggaSwhsXthM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776877420; c=relaxed/simple; bh=sGU1Ygg4261DH8TZQZe0ZVqJxWuJ8RwjWKefE4X9LQ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BJBbngwG6uLtEnpKtyQ6iGCnBVWpWX+mMdwz1uMYF4LNNEKi/iI5mv62zMBOQ7TowZUsbIHVpizEUl1K2OYYvmGx7QaTUnz9PZe1aT4I4XNVNYVmIP30NUHbo4iGXm7hWZp92t26DbpB7s/Ebcy+MDtFFq1hJ+JSolwxstR5WI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oim5eBkH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oim5eBkH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F5F2C19425; Wed, 22 Apr 2026 17:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776877419; bh=sGU1Ygg4261DH8TZQZe0ZVqJxWuJ8RwjWKefE4X9LQ0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oim5eBkHgAMIMizlFEaaThX/7+30AN3978aOFCr6w6KytlJrvaZVfZgKzv0snfwFD 4Ji7lQRWTTOyB/pvRK2ownamp/4jOIYVAFTjA9GY1bjSOoq0QtReY+YGprogHS34fF 76sJSIM7SYtVkwxVWBjHr7zP0BfDh61aOLrP86yu70TU8e63n1auyySa+UEL9FOt5B +hjbA1l2xSnYFZ1DlanzyFRemZv9A2rOXOzOaUNHJqADa5E4mNu3YHtzMTOuokWjiw zloQ90zQe3X8ZO61OCWK2VyxOIMO/5mEUIXDmt+Q51D8wTE9IV6BLbvPdztDkn0gzD 9YafaW9JZ1flw== Message-ID: <88096a1b-0c16-40ae-a03a-0d0d7f1702a4@kernel.org> Date: Wed, 22 Apr 2026 19:03:33 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2] mptcp: do not drop partial packets To: Shardul Bankar , pabeni@redhat.com, martineau@kernel.org Cc: geliang@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, horms@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, janak@mpiric.us, kalpan.jani@mpiricsoftware.com, Shardul Bankar References: <20260422143931.43281-1-shardul.b@mpiricsoftware.com> From: Matthieu Baerts Content-Language: fr Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20260422143931.43281-1-shardul.b@mpiricsoftware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Shardul, On 22/04/2026 16:39, Shardul Bankar wrote: > When a packet arrives with map_seq < ack_seq < end_seq, the beginning > of the packet has already been acknowledged but the end contains new > data. Currently the entire packet is dropped as "old data," forcing > the sender to retransmit. > > Instead, skip the already-acked bytes by adjusting the skb offset and > enqueue only the new portion. Update bytes_received and ack_seq to > reflect the new data consumed. Thank you for the v2. I didn't review it (yet), but just to let you know that there are some rules on Netdev [1] (that usually also applied on MPTCP side), and an important one is: - don't repost your patches within one 24h period Each version generates a lot of emails that are sent and need to be triaged. With the high volume, it is then harder for us to follow, plus a lot of shared resources are used, etc. One last thing, because this patch is not an urgent fix, do you mind sending new versions only the to MPTCP ML: to a restricted number of people for the first versions, there is enough traffic on Netdev. [1] https://docs.kernel.org/process/maintainer-netdev.html > A previous attempt at this fix (commit 1d2ce718811a ("mptcp: do not > drop partial packets"), reverted in commit bf39160c4218 ("Revert Note: these two commits should not be mentioned here, they have only been applied to the MPTCP tree, but not upstreamed. Instead, please use lore links, e.g. https://lore.kernel.org/c9b426a4e163aa3c4fe8b80c79f1a610f47ae7d8.1763075056.git.pabeni@redhat.com > "mptcp: do not drop partial packets"")) also added a zero-window > check and changed rcv_wnd_sent initialization, which caused test > regressions. This version addresses only the partial packet handling > without modifying receive window accounting. > > Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue.") > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/600 > Signed-off-by: Shardul Bankar Checkpatch is complaining that the author of the patch is not the same as the one who sent the patch; You probably need to run this command to fix it: git commit --amend --reset-author (when the patch is sent, `git format-patch` will add a second From: tag) Cheers, Matt -- Sponsored by the NGI0 Core fund.