RE: [net-next 02/11] e1000: Adding e1000_dump function

Dave, Tushar N
2012-02-08T18:39:37Z

>-----Original Message-----
>From: Michal Kubeček [mailto:mkubecek@suse.cz]
>Sent: Tuesday, February 07, 2012 9:38 AM
>To: netdev@vger.kernel.org
>Cc: Kirsher, Jeffrey T; davem@davemloft.net; Dave, Tushar N;
>gospo@redhat.com; sassmann@redhat.com; jbeulich@suse.com
>Subject: Re: [net-next 02/11] e1000: Adding e1000_dump function
>
>On Tuesday 07 of February 2012 04:33EN, Jeff Kirsher wrote:
>> + if (netif_msg_pktdata(adapter) && buffer_info->dma != 0)
>> + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS,
>> + 16, 1, phys_to_virt(buffer_info->dma),
>> + buffer_info->length, true);
>
>This might cause problems in Xen environment, we encountered a crash in
>e1000e where phys_to_virt() is used the same way. I'm not familiar with
>the details but this is what Jan Beulich wrote about it:

How did you fix the problem in e1000e then? I don't see bus_to_virt used in any of our Ethernet drivers.
Also when running in Xen which arch are you running on?

-Tushar