From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A22C43381 for ; Sat, 23 Feb 2019 22:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 350A120665 for ; Sat, 23 Feb 2019 22:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727927AbfBWWNJ (ORCPT ); Sat, 23 Feb 2019 17:13:09 -0500 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:45177 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726217AbfBWWNI (ORCPT ); Sat, 23 Feb 2019 17:13:08 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 6E8CE52C5; Sat, 23 Feb 2019 22:13:07 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: key74_8f7992cb8a25c X-Filterd-Recvd-Size: 2191 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sat, 23 Feb 2019 22:13:05 +0000 (UTC) Message-ID: <8827ff6b60d73ca6484365d25f72ec82ac106c40.camel@perches.com> Subject: Re: [PATCH v3 net-next 2/2] net: sock: undefine SOCK_DEBUGGING From: Joe Perches To: David Miller , laoar.shao@gmail.com Cc: daniel@iogearbox.net, edumazet@google.com, xiyou.wangcong@gmail.com, netdev@vger.kernel.org, shaoyafang@didiglobal.com Date: Sat, 23 Feb 2019 14:13:04 -0800 In-Reply-To: <20190223.132117.343025457687449183.davem@davemloft.net> References: <1550413592-7877-1-git-send-email-laoar.shao@gmail.com> <1550413592-7877-3-git-send-email-laoar.shao@gmail.com> <20190223.132117.343025457687449183.davem@davemloft.net> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2019-02-23 at 13:21 -0800, David Miller wrote: > From: Yafang Shao > Date: Sun, 17 Feb 2019 22:26:32 +0800 > > > SOCK_DEBUG() is a old facility for debugging. > > If the user want to use it for debugging, the user must modify the > > application first, that doesn't seem like a good way. > > Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind > > of debugging purpose. > > So we'd better disable it by default. > > The reason why I don't remove it comepletely is that someone may still > > would like to use it for debugging. > > > > Signed-off-by: Yafang Shao > > Suggested-by: Joe Perches > > Sorry, I'm not applying this. > > You are forcing everyone who wants to use this to add a curstom local > source code change into their build. That may not actually be a bad thing. It could become a CONFIG bit too. I'm not sure how often it's actually used. Outside of the likely to be removed tcp uses, it's currently used only in appletalk/ddp, x25, and the 1 use in dccp. All of the existing uses could likely be removed without much notice by anyone.