From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f173.google.com ([209.85.216.173]:37211 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966042AbeCSRpT (ORCPT ); Mon, 19 Mar 2018 13:45:19 -0400 Received: by mail-qt0-f173.google.com with SMTP id a23so18881815qtm.4 for ; Mon, 19 Mar 2018 10:45:18 -0700 (PDT) Subject: Re: [PATCH net-next 0/4] net: dsa: Plug in PHYLINK support To: Andrew Lunn Cc: netdev@vger.kernel.org, privat@egil-hjelmeland.no, vivien.didelot@savoirfairelinux.com, davem@davemloft.net, rmk+kernel@armlinux.org.uk, sean.wang@mediatek.com, Woojung.Huh@microchip.com, john@phrozen.org, cphealy@gmail.com References: <20180318185246.19311-1-f.fainelli@gmail.com> <5690f51e-e303-70ad-f08e-915674efd854@gmail.com> <20180319134438.GE26039@lunn.ch> From: Florian Fainelli Message-ID: <88771bb1-242f-871c-bd5c-202378132015@gmail.com> Date: Mon, 19 Mar 2018 10:45:09 -0700 MIME-Version: 1.0 In-Reply-To: <20180319134438.GE26039@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 03/19/2018 06:44 AM, Andrew Lunn wrote: >> I think I will proceed differently for v2: >> >> - introduce DSA phylink_mac_ops in dsa_switch_ops, such that drivers can >> define those as preliminary commits, those won't be used by >> net/dsa/slave.c just yet though >> >> - have all relevant drivers implement phylink_mac_ops such that the >> pluming is there and functional >> >> - switch net/dsa/slave.c to using PHYLINK >> >> That way, we should avoid any breakage in between and have an "atomic" >> switch between PHYLIB and PHYLINK. > > Hi Florian > > That sounds good. Maybe we can also convert ZII devel B to using SFP > at the same time? That should be done, yes. > > I can take a look at implementing the Marvell phylink_mac_ops. If you could do that, I would be grateful, without the datasheet things will take time to be reverse engineered for me. AFAIR, Russell had sent us patches separately that he used. The way the patch series is structured right now, only the user-facing ports will need to have phylink_mac_ops, which should help reduce the amount of testing. Thanks! -- Florian