From: Jay Vosburgh <fubar@us.ibm.com>
To: David Strand <dpstrand@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bonding: check for assigned mac before adopting the slaves mac address
Date: Thu, 25 Nov 2010 19:26:31 -0800 [thread overview]
Message-ID: <8879.1290741991@death> (raw)
In-Reply-To: <AANLkTi=-DzUmopboX13V_cd=mZnmD=mBNNCuhQYF0PQQ@mail.gmail.com>
David Strand <dpstrand@gmail.com> wrote:
>We have a use case where we assign a mac to the bond device, because
>the slave device configuration may change periodically. With older
>kernels, it honored the assigned mac and everything was fine, with
>2.6.36 it now uses the mac of whatever slave device is first instead
>of our assigned one.
>
>ifenslave code and documentation appears to still support the old way,
>where a bond assigned mac will reign supreme, so this patch restores
>that behavior.
Ok, fair enough. If we want to get back to the original
behavior, however, your patch should only test for zero MAC address
instead of testing for zero MAC address in addition to first slave.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2010-11-26 3:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 23:12 [PATCH] bonding: check for assigned mac before adopting the slaves mac address David Strand
2010-11-24 23:33 ` Jay Vosburgh
2010-11-25 0:44 ` Laurent Chavey
2010-11-25 1:45 ` David Strand
2010-11-26 3:26 ` Jay Vosburgh [this message]
2010-12-01 18:25 ` David Strand
2010-12-01 18:45 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2010-12-01 19:15 David Strand
2010-12-01 19:21 ` Jay Vosburgh
2010-12-01 19:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8879.1290741991@death \
--to=fubar@us.ibm.com \
--cc=dpstrand@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).