From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A4F3AC04AA5
	for <netdev@archiver.kernel.org>; Thu, 25 Aug 2022 06:47:40 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229909AbiHYGrh (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 25 Aug 2022 02:47:37 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59918 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234152AbiHYGrb (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 25 Aug 2022 02:47:31 -0400
Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC92B67159
        for <netdev@vger.kernel.org>; Wed, 24 Aug 2022 23:47:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding:
        Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender
        :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To:
        Resent-Cc:Resent-Message-ID; bh=Q4WHOBmkaRKitCyCS+aQFVYkWWsSEjaAM36zcjGfVaU=;
        t=1661410050; x=1662619650; b=hwYlnOe5q4mT2Tl6NWQ7Wk7bjg/Rq2kNo5F9QCM4ZyAWy1C
        +tn31K7V+XKMMsi7vE8eUJFfEnQUG7ibj6u3n7Kw7DgGyfmTAymUrMp7zQNyCmqd7RIOaxhTOGZgX
        8fZtKRzXdWzRrjC9Mc0d5UHz2cotFkMDqzfuCGNETfdAnYfxzkal/jyhINYXkYVW44FS4OJD4mXbs
        7oe2FYeIr3XmBXTaG9cjYlzEFirefXtGR+iPkUHH7YceeFsTYaZwxGHIh4wB9QwxGbtu/uD6edoLu
        vZbt5FzQBndsJjQ94agZNbXiDJRkBcWD8B/R2zOCP7QegZVz8sGcl4hfhNLkanAw==;
Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)
        (Exim 4.96)
        (envelope-from <johannes@sipsolutions.net>)
        id 1oR6eB-00GvxR-2a;
        Thu, 25 Aug 2022 08:47:23 +0200
Message-ID: <88ae3fffb15a5fe20c7d61c2b53d4002383b20ea.camel@sipsolutions.net>
Subject: Re: [PATCH net-next v2 1/6] netlink: factor out extack composition
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc:     netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
        mkubecek@suse.cz, fw@strlen.de
Date:   Thu, 25 Aug 2022 08:47:22 +0200
In-Reply-To: <20220825024122.1998968-2-kuba@kernel.org>
References: <20220825024122.1998968-1-kuba@kernel.org>
         <20220825024122.1998968-2-kuba@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
X-malware-bazaar: not-scanned
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Wed, 2022-08-24 at 19:41 -0700, Jakub Kicinski wrote:
>=20
> +static void
> +netlink_ack_tlv_fill(struct sk_buff *in_skb, struct sk_buff *skb,
> +		     struct nlmsghdr *nlh,  int err,

nit: two spaces

johannes