From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9146BC4321E for ; Thu, 1 Dec 2022 21:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230264AbiLAVBp (ORCPT ); Thu, 1 Dec 2022 16:01:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbiLAVBd (ORCPT ); Thu, 1 Dec 2022 16:01:33 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 075D5BEC71; Thu, 1 Dec 2022 13:01:25 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so3282567pjd.5; Thu, 01 Dec 2022 13:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LRq1OL6Xj9pmq08PnRJaytzi6oZ4smB3yIcsOA6bRZ8=; b=mL/QChE2IM6Sa+fr7sGjHdhpKLgydMltDYaZP3WHB98HQTtWKBzZBJ+MlB5LKoS6kr CKU4uuTE1Qs8d5dKkTq2KSCAtX1qlVYGnIF9pNZdwIaPZHBlQj58xst48Nev03oEO3G9 ox/cIyJuMcOv7BrK67pVJgaJLOOcfh2HAJCj92YKqru70tPx+HFip1yh90mLfEVvXeSH +vgF4D0ALutmTZH4ZIHjzWWH3qg/Fm7p/XMXL7ahtnulI5XkQlVIiTqOCdQut3OgFx9X Li/+WJutX+j0Tc1GoJxIaiml4E4ZOS1ZJFE6KUAiMSRs0tkNI0CQkLtsFvKae+Iqe2AB /BHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LRq1OL6Xj9pmq08PnRJaytzi6oZ4smB3yIcsOA6bRZ8=; b=wADOf3r278pLYrGKCeP+G/FNGyW+Zbh97IbGaD2E+wDuo0wnld5xk4Ogvt1T3zSm7H ncU4hgrG2V2VM1le8uPAw/PCTxYbuYZ4UqF8SoazVVXHNfrKDsu9X/s3QJTCqThrr0x9 aU5ztkbHVjQEt2Je23hb0/43Gu+EWtcFcA6pusbyBGGEUQA5OQf5UOVapTfRTGWL7A2S kiuXO7agSf6G92h7R+YmOMp7jLoLnGJsvlXcI4d/bQf25WHKz4Rx2az1EZveZv6i3epi Q6bZaJIXkFF0ltfvGaVOeF2xI53i/kxX6qbE3YRvllPb9tBgmf0suvTjKtdCUttQIXKG KCrA== X-Gm-Message-State: ANoB5pnhPb+8HhjrInVTM2R/uNiLH/8Y9thSY8eTQjk8ygzpd/1XMkGs BOA3diEIsEkIgvyDYqB/dfA= X-Google-Smtp-Source: AA0mqf6kwzXSHtomF6UgbQTjc6L42lOm5imMB/D9GPDhjeLMYdCotgUgkirKWbp5mNXOVt2pLOH85A== X-Received: by 2002:a17:902:6a86:b0:187:722:f4db with SMTP id n6-20020a1709026a8600b001870722f4dbmr50441108plk.87.1669928485074; Thu, 01 Dec 2022 13:01:25 -0800 (PST) Received: from ?IPV6:2600:8802:b00:4a48:edbb:db52:d3ff:52f? ([2600:8802:b00:4a48:edbb:db52:d3ff:52f]) by smtp.gmail.com with ESMTPSA id a15-20020aa78e8f000000b005743cdde1a7sm3643147pfr.82.2022.12.01.13.01.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 13:01:24 -0800 (PST) Message-ID: <88dda176-cfbd-5351-970c-93d5aa598aaa@gmail.com> Date: Thu, 1 Dec 2022 13:01:23 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 1/3] net: dsa: ksz: Check return value Content-Language: en-US To: Artem Chernyshev , Vladimir Oltean , Woojung Huh Cc: "David S . Miller" , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20221201140032.26746-1-artem.chernyshev@red-soft.ru> From: Florian Fainelli In-Reply-To: <20221201140032.26746-1-artem.chernyshev@red-soft.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/1/2022 6:00 AM, Artem Chernyshev wrote: > Return NULL if we got unexpected value from skb_trim_rcsum() > in ksz_common_rcv() > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: bafe9ba7d908 ("net: dsa: ksz: Factor out common tag code") > Signed-off-by: Artem Chernyshev > Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian