From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 4/8] r8169: replace synchronize_rcu with synchronize_net
Date: Wed, 17 Jun 2020 22:53:21 +0200 [thread overview]
Message-ID: <8924ccae-fac3-aae5-dd9a-711a1ef861d1@gmail.com> (raw)
In-Reply-To: <ef2a4cd4-1492-99d8-f94f-319eeb129137@gmail.com>
rtl8169_hw_reset() may be called under RTNL lock, therefore switch to
synchronize_net().
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index bd95c0ae6..0d3e58ae1 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -3929,7 +3929,7 @@ static void rtl8169_tx_clear(struct rtl8169_private *tp)
static void rtl8169_hw_reset(struct rtl8169_private *tp, bool going_down)
{
/* Give a racing hard_start_xmit a few cycles to complete. */
- synchronize_rcu();
+ synchronize_net();
/* Disable interrupts */
rtl8169_irq_mask_and_ack(tp);
--
2.27.0
next prev parent reply other threads:[~2020-06-17 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 20:50 [PATCH net-next 0/8] r8169: smaller improvements again Heiner Kallweit
2020-06-17 20:51 ` [PATCH net-next 1/8] r8169: add info for DASH being enabled Heiner Kallweit
2020-06-17 20:51 ` [PATCH net-next 2/8] r8169: remove unused constant RsvdMask Heiner Kallweit
2020-06-17 20:52 ` [PATCH net-next 3/8] r8169: improve setting WoL on runtime-resume Heiner Kallweit
2020-06-17 20:53 ` Heiner Kallweit [this message]
2020-06-17 20:54 ` [PATCH net-next 5/8] r8169: move napi_disable call and rename rtl8169_hw_reset Heiner Kallweit
2020-06-17 20:54 ` [PATCH net-next 6/8] r8169: move updating counters to rtl8169_down Heiner Kallweit
2020-06-17 20:55 ` [PATCH net-next 7/8] r8169: move switching optional clock on/off to pll power functions Heiner Kallweit
2020-06-17 20:56 ` [PATCH net-next 8/8] r8169: allow setting irq coalescing if link is down Heiner Kallweit
2020-06-19 3:40 ` [PATCH net-next 0/8] r8169: smaller improvements again David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8924ccae-fac3-aae5-dd9a-711a1ef861d1@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).