From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>,
linux-netdev <netdev@vger.kernel.org>
Cc: Andy Gospodarek <andy@greyhouse.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: bonding: Completion of error handling around bond_update_slave_arr()
Date: Thu, 4 Jan 2018 22:41:08 +0100 [thread overview]
Message-ID: <892dbd56-ec95-8244-540a-cbd53db62ec7@users.sourceforge.net> (raw)
In-Reply-To: <CAF2d9jjyfWT8Nm1V3fCKSrEE4Xs9gShs7nvj+dAYqXg42kUhvg@mail.gmail.com>
>>> If you see 8 out of 9 call sites in this file ignore the return value.
>>
>> How do you think about to fix error detection and corresponding
>> exception handling then?
>>
> If I understand your question correctly - not having memory is not a
> correctable error
I am unsure if it would be feasible to retry memory allocations for
this software module under other circumstances.
> and hence there are consequences.
Could one consequence be to let the error code “-ENOMEM” move through
the function call hierarchy?
Regards,
Markus
prev parent reply other threads:[~2018-01-04 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 16:07 [PATCH] bonding: Delete an error message for a failed memory allocation in bond_update_slave_arr() SF Markus Elfring
2018-01-03 7:00 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-03 8:45 ` SF Markus Elfring
2018-01-03 19:28 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-03 21:58 ` Eric Dumazet
2018-01-04 8:19 ` bonding: Completion of error handling around bond_update_slave_arr() SF Markus Elfring
2018-01-04 18:52 ` Mahesh Bandewar (महेश बंडेवार)
2018-01-04 21:41 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=892dbd56-ec95-8244-540a-cbd53db62ec7@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).