From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] net: phy: qcom: qca807x: normalize return value of gpio_get
Date: Wed, 18 Feb 2026 15:01:22 -0800 [thread overview]
Message-ID: <893C889D-3440-4DCC-904F-CA4228C48C50@gmail.com> (raw)
In-Reply-To: <ba73d17a-1d7c-4e66-af6b-d8e5a37358f2@lunn.ch>
On February 18, 2026 2:55:32 PM PST, Andrew Lunn <andrew@lunn.ch> wrote:
>On Wed, Feb 18, 2026 at 12:57:17PM -0800, Dmitry Torokhov wrote:
>> The GPIO get callback is expected to return 0 or 1 (or a negative error
>> code). Ensure that the value returned by qca807x_gpio_get() is
>> normalized to the [0, 1] range.
>>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
>This appears to be a fix. Please add a Fixes: tag.
>
>Also, please put net into the Subject.
>
>https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Will do, however I am not sure what should be tagged as "Fixes" - original driver commit or the change in gpiolib tightening the checks?
Thanks!
--
Dmitry
next prev parent reply other threads:[~2026-02-18 23:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 20:57 [PATCH] net: phy: qcom: qca807x: normalize return value of gpio_get Dmitry Torokhov
2026-02-18 22:55 ` Andrew Lunn
2026-02-18 23:01 ` Dmitry Torokhov [this message]
2026-02-18 23:11 ` Andrew Lunn
2026-02-19 10:48 ` Bartosz Golaszewski
2026-02-19 18:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893C889D-3440-4DCC-904F-CA4228C48C50@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=andrew@lunn.ch \
--cc=brgl@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox