From: Paolo Abeni <pabeni@redhat.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>, Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
willemb@google.com
Subject: Re: [PATCH net-next v2 0/2] net: flow dissector: allow explicit passing of netns
Date: Thu, 27 Jun 2024 12:20:00 +0200 [thread overview]
Message-ID: <8942458c0cb74b25cffedf975f8a37d7ed572765.camel@redhat.com> (raw)
In-Reply-To: <ZnypC7iOx_qtUH37@calendula>
On Thu, 2024-06-27 at 01:49 +0200, Pablo Neira Ayuso wrote:
> This series got applied to net-next.
>
> But I can trigger this splat via nftables/tests/shell in net.git (6.10-rc).
>
> As well as in -stable 6.1.x:
>
> Jun 26 02:19:26 curiosity kernel: [ 1211.840595] ------------[ cut here ]------------
> Jun 26 02:19:26 curiosity kernel: [ 1211.840605] WARNING: CPU: 0 PID: 70274 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0x107e/0x2860
> [...]
> Jun 26 02:19:26 curiosity kernel: [ 1211.841240] CPU: 0 PID: 70274 Comm: socat Not tainted 6.1.93+ #18
>
> I think that turning this into DEBUG_NET_WARN_ON_ONCE as Willem
> suggested provides a workaround for net.git until Florian's fixes in
> net-next hit -stable.
>
> Would you accept such a patch?
FWISW I think it makes sense.
Thanks,
Paolo
prev parent reply other threads:[~2024-06-27 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-08 22:10 [PATCH net-next v2 0/2] net: flow dissector: allow explicit passing of netns Florian Westphal
2024-06-08 22:10 ` [PATCH net-next v2 1/2] net: add and use skb_get_hash_net Florian Westphal
2024-06-08 22:10 ` [PATCH net-next v2 2/2] net: add and use __skb_get_hash_symmetric_net Florian Westphal
2024-06-09 5:06 ` [PATCH net-next v2 0/2] net: flow dissector: allow explicit passing of netns Eric Dumazet
2024-06-12 22:00 ` patchwork-bot+netdevbpf
2024-06-26 23:49 ` Pablo Neira Ayuso
2024-06-27 10:20 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8942458c0cb74b25cffedf975f8a37d7ed572765.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox