From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next v2] net: dsa: make "label" property optional for dsa2 Date: Mon, 9 Jan 2017 09:42:07 -0800 Message-ID: <89492624-84f2-ca73-75dd-7fa10819ad09@gmail.com> References: <20170108231552.26995-1-vivien.didelot@savoirfairelinux.com> <20170109073236.GA1862@nanopsycho> <877f6446lp.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <20170109151131.GC1862@nanopsycho> <87y3yk2q5e.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <20170109160632.GD1862@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Andrew Lunn , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Andrey Smirnov To: Jiri Pirko , Vivien Didelot Return-path: In-Reply-To: <20170109160632.GD1862@nanopsycho> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 01/09/2017 08:06 AM, Jiri Pirko wrote: > Mon, Jan 09, 2017 at 04:45:33PM CET, vivien.didelot@savoirfairelinux.com wrote: >> Hi Jiri, >> >> Jiri Pirko writes: >> >>>> Extra question: shouldn't phys_port_{id,name} be switchdev attributes in >>> >>> Again, phys_port_id has nothing to do with switches. Should be removed >>> from dsa because its use there is incorrect. >> >> Florian, since 3a543ef just got in, can it be reverted? > > Yes, please revert it. It is only in net-next. Maybe the use case can be understood before reverting the change. How do we actually the physical port number of an Ethernet switch per-port network device? The name is not enough, because there are plenty of cases where we need to manipulate a physical port number (be it just for informational purposes). Should we just amend the existing description of ndo_get_phys_port_id()? Should we introduce another ndo for that? -- Florian