From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
Cc: netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH net-next] virtio_net: don't reset twice on XDP on/off
Date: Thu, 30 Mar 2017 13:39:49 +0800 [thread overview]
Message-ID: <8949b5e9-602d-eef0-acdb-9f0f9a5a6f54@redhat.com> (raw)
In-Reply-To: <1490818456-6861-1-git-send-email-mst@redhat.com>
On 2017年03月30日 04:14, Michael S. Tsirkin wrote:
> We already do a reset once in remove_vq_common -
> there appears to be no point in doing another one
> when we add/remove XDP.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index de42e9a..ed8f548 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1810,7 +1810,6 @@ static int virtnet_reset(struct virtnet_info *vi, int curr_qp, int xdp_qp)
> virtnet_freeze_down(dev);
> _remove_vq_common(vi);
>
> - dev->config->reset(dev);
> virtio_add_status(dev, VIRTIO_CONFIG_S_ACKNOWLEDGE);
> virtio_add_status(dev, VIRTIO_CONFIG_S_DRIVER);
>
Acked-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2017-03-30 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 20:14 [PATCH net-next] virtio_net: don't reset twice on XDP on/off Michael S. Tsirkin
2017-03-30 5:39 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8949b5e9-602d-eef0-acdb-9f0f9a5a6f54@redhat.com \
--to=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).