* [PATCH] net: dsa: b53: mmap: fix device tree support
@ 2023-03-10 12:10 Álvaro Fernández Rojas
2023-03-15 7:06 ` Jakub Kicinski
2023-03-16 17:28 ` [PATCH v2] " Álvaro Fernández Rojas
0 siblings, 2 replies; 6+ messages in thread
From: Álvaro Fernández Rojas @ 2023-03-10 12:10 UTC (permalink / raw)
To: f.fainelli, jonas.gorski, andrew, olteanv, davem, edumazet, kuba,
pabeni, netdev, linux-kernel
Cc: Álvaro Fernández Rojas
B53_CPU_PORT should also be enabled in order to get a working switch.
Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/net/dsa/b53/b53_mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
index e968322dfbf0..24ea2e19dfa6 100644
--- a/drivers/net/dsa/b53/b53_mmap.c
+++ b/drivers/net/dsa/b53/b53_mmap.c
@@ -263,7 +263,7 @@ static int b53_mmap_probe_of(struct platform_device *pdev,
if (of_property_read_u32(of_port, "reg", ®))
continue;
- if (reg < B53_CPU_PORT)
+ if (reg <= B53_CPU_PORT)
pdata->enabled_ports |= BIT(reg);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: b53: mmap: fix device tree support
2023-03-10 12:10 [PATCH] net: dsa: b53: mmap: fix device tree support Álvaro Fernández Rojas
@ 2023-03-15 7:06 ` Jakub Kicinski
2023-03-15 18:29 ` Florian Fainelli
2023-03-16 17:28 ` [PATCH v2] " Álvaro Fernández Rojas
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2023-03-15 7:06 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: f.fainelli, jonas.gorski, andrew, olteanv, davem, edumazet,
pabeni, netdev, linux-kernel
On Fri, 10 Mar 2023 13:10:59 +0100 Álvaro Fernández Rojas wrote:
> diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
> index e968322dfbf0..24ea2e19dfa6 100644
> --- a/drivers/net/dsa/b53/b53_mmap.c
> +++ b/drivers/net/dsa/b53/b53_mmap.c
> @@ -263,7 +263,7 @@ static int b53_mmap_probe_of(struct platform_device *pdev,
> if (of_property_read_u32(of_port, "reg", ®))
> continue;
>
> - if (reg < B53_CPU_PORT)
> + if (reg <= B53_CPU_PORT)
> pdata->enabled_ports |= BIT(reg);
Should we switch to B53_N_PORTS instead?
That's the bound used by the local "for each port" macro:
#define b53_for_each_port(dev, i) \
for (i = 0; i < B53_N_PORTS; i++) \
if (dev->enabled_ports & BIT(i))
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net: dsa: b53: mmap: fix device tree support
2023-03-15 7:06 ` Jakub Kicinski
@ 2023-03-15 18:29 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2023-03-15 18:29 UTC (permalink / raw)
To: Jakub Kicinski, Álvaro Fernández Rojas
Cc: jonas.gorski, andrew, olteanv, davem, edumazet, pabeni, netdev,
linux-kernel
On 3/15/23 00:06, Jakub Kicinski wrote:
> On Fri, 10 Mar 2023 13:10:59 +0100 Álvaro Fernández Rojas wrote:
>> diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
>> index e968322dfbf0..24ea2e19dfa6 100644
>> --- a/drivers/net/dsa/b53/b53_mmap.c
>> +++ b/drivers/net/dsa/b53/b53_mmap.c
>> @@ -263,7 +263,7 @@ static int b53_mmap_probe_of(struct platform_device *pdev,
>> if (of_property_read_u32(of_port, "reg", ®))
>> continue;
>>
>> - if (reg < B53_CPU_PORT)
>> + if (reg <= B53_CPU_PORT)
>> pdata->enabled_ports |= BIT(reg);
>
> Should we switch to B53_N_PORTS instead?
> That's the bound used by the local "for each port" macro:
>
> #define b53_for_each_port(dev, i) \
> for (i = 0; i < B53_N_PORTS; i++) \
> if (dev->enabled_ports & BIT(i))
Yes, checking against B53_N_PORTS would be a better check.
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net: dsa: b53: mmap: fix device tree support
2023-03-10 12:10 [PATCH] net: dsa: b53: mmap: fix device tree support Álvaro Fernández Rojas
2023-03-15 7:06 ` Jakub Kicinski
@ 2023-03-16 17:28 ` Álvaro Fernández Rojas
2023-03-16 17:30 ` Florian Fainelli
2023-03-18 5:00 ` patchwork-bot+netdevbpf
1 sibling, 2 replies; 6+ messages in thread
From: Álvaro Fernández Rojas @ 2023-03-16 17:28 UTC (permalink / raw)
To: f.fainelli, jonas.gorski, andrew, olteanv, davem, edumazet, kuba,
pabeni, netdev, linux-kernel
Cc: Álvaro Fernández Rojas
CPU port should also be enabled in order to get a working switch.
Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
v2: switch to B53_N_PORTS
drivers/net/dsa/b53/b53_mmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c
index e968322dfbf0..70887e0aece3 100644
--- a/drivers/net/dsa/b53/b53_mmap.c
+++ b/drivers/net/dsa/b53/b53_mmap.c
@@ -263,7 +263,7 @@ static int b53_mmap_probe_of(struct platform_device *pdev,
if (of_property_read_u32(of_port, "reg", ®))
continue;
- if (reg < B53_CPU_PORT)
+ if (reg < B53_N_PORTS)
pdata->enabled_ports |= BIT(reg);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] net: dsa: b53: mmap: fix device tree support
2023-03-16 17:28 ` [PATCH v2] " Álvaro Fernández Rojas
@ 2023-03-16 17:30 ` Florian Fainelli
2023-03-18 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2023-03-16 17:30 UTC (permalink / raw)
To: Álvaro Fernández Rojas, jonas.gorski, andrew, olteanv,
davem, edumazet, kuba, pabeni, netdev, linux-kernel
On 3/16/23 10:28, Álvaro Fernández Rojas wrote:
> CPU port should also be enabled in order to get a working switch.
>
> Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] net: dsa: b53: mmap: fix device tree support
2023-03-16 17:28 ` [PATCH v2] " Álvaro Fernández Rojas
2023-03-16 17:30 ` Florian Fainelli
@ 2023-03-18 5:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-18 5:00 UTC (permalink / raw)
To: =?utf-8?q?=C3=81lvaro_Fern=C3=A1ndez_Rojas_=3Cnoltari=40gmail=2Ecom=3E?=
Cc: f.fainelli, jonas.gorski, andrew, olteanv, davem, edumazet, kuba,
pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 16 Mar 2023 18:28:07 +0100 you wrote:
> CPU port should also be enabled in order to get a working switch.
>
> Fixes: a5538a777b73 ("net: dsa: b53: mmap: Add device tree support")
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v2: switch to B53_N_PORTS
>
> [...]
Here is the summary with links:
- [v2] net: dsa: b53: mmap: fix device tree support
https://git.kernel.org/netdev/net/c/30796d0dcb6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-18 5:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-10 12:10 [PATCH] net: dsa: b53: mmap: fix device tree support Álvaro Fernández Rojas
2023-03-15 7:06 ` Jakub Kicinski
2023-03-15 18:29 ` Florian Fainelli
2023-03-16 17:28 ` [PATCH v2] " Álvaro Fernández Rojas
2023-03-16 17:30 ` Florian Fainelli
2023-03-18 5:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).