From: Paolo Abeni <pabeni@redhat.com>
To: Thangaraj Samynathan <Thangaraj.S@microchip.com>, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, horms@kernel.org, bryan.whitehead@microchip.com,
UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH net-next v5 1/2] net: lan743x: add RMII strap status detection for PCI11x1x
Date: Thu, 30 Jul 2026 10:19:13 +0200 [thread overview]
Message-ID: <89b0aff1-d639-4366-9ff2-86260130d532@redhat.com> (raw)
In-Reply-To: <20260723050827.694832-2-Thangaraj.S@microchip.com>
On 7/23/26 7:08 AM, Thangaraj Samynathan wrote:
> From: Thangaraj Samynathan <thangaraj.s@microchip.com>
>
> Extend pci11x1x_strap_get_status() to read the RMII strap bits from
> the STRAP_READ register. The is_rmii_en flag is initialized to
> false and updated based on the hardware strap only if SGMII is not
> already enabled. This ensures correct interface identification during
> adapter initialization.
>
> Update the netif_dbg() to report the selected interface as SGMII,
> RMII, or RGMII.
>
> Signed-off-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
Noting that this series splitting confused Sashiko quite a bit, but the
reported "issues" is actually addresses by the next patch.
Also noting you should have discussed this point proactively, see
net-next commit c82ff94592fb.
/P
next prev parent reply other threads:[~2026-07-30 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 5:08 [RESEND PATCH net-next v5 0/2] net: lan743x: add RMII support for PCI11x1x Thangaraj Samynathan
2026-07-23 5:08 ` [RESEND PATCH net-next v5 1/2] net: lan743x: add RMII strap status detection " Thangaraj Samynathan
2026-07-30 8:19 ` Paolo Abeni [this message]
2026-07-23 5:08 ` [RESEND PATCH net-next v5 2/2] net: lan743x: add support for RMII interface Thangaraj Samynathan
2026-07-30 8:30 ` [RESEND PATCH net-next v5 0/2] net: lan743x: add RMII support for PCI11x1x patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89b0aff1-d639-4366-9ff2-86260130d532@redhat.com \
--to=pabeni@redhat.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox