public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Eric Dumazet <edumazet@google.com>,
	Simon Horman <horms@kernel.org>,
	Fernando Gont <fgont@si6networks.com>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org,
	davem@davemloft.net
Subject: Re: [PATCH net] ipv6: addrconf: reduce default temp_valid_lft to 2 days
Date: Sat, 14 Feb 2026 14:27:55 +0100	[thread overview]
Message-ID: <89d03f27-2e08-4619-b556-772da4c38462@suse.de> (raw)
In-Reply-To: <8c9727bc-a1d5-4ea3-8318-f3fa7e558c85@suse.de>



On 2/13/26 3:44 PM, Fernando Fernandez Mancera wrote:
> On 2/13/26 3:34 PM, Eric Dumazet wrote:
>> On Fri, Feb 13, 2026 at 3:00 PM Simon Horman <horms@kernel.org> wrote:
>>>
>>> On Wed, Feb 11, 2026 at 09:20:03PM +0100, Fernando Fernandez Mancera 
>>> wrote:
>>>> This is a recommendation from RFC 8981 and it was intended to be 
>>>> changed
>>>> by commit 969c54646af0 ("ipv6: Implement draft-ietf-6man-rfc4941bis")
>>>> but it only changed the sysctl documentation.
>>>>
>>>> Fixes: 969c54646af0 ("ipv6: Implement draft-ietf-6man-rfc4941bis")
>>>> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
>>>
>>> Reviewed-by: Simon Horman <horms@kernel.org>
>>
>>
>> I would recommend adding a comment, because final RFC states
>> "TEMP_VALID_LIFETIME -- Default value: 1 week. Users should be able
>> to override the default value.
>>
>> https://datatracker.ietf.org/doc/html/rfc4941#section-5
>>
>> So... do we still need a different value in linux, and why ?
>>
> 
> RFC 8981 obsoletes RFC 4941, the new RFC states
> "TEMP_VALID_LIFETIME -- Default value: 2 days. Users should be able to 
> override the default value."
> 
> https://datatracker.ietf.org/doc/html/rfc8981#section-3.8
> 
> I didn't include the reasoning because it was already on the blamed 
> commit which comes from the RFC 8981 too.
> 
> https://datatracker.ietf.org/doc/html/rfc8981#section-4
> 
> Anyway, I am fine adding a comment or mentioning it on the commit 
> message if needed.
> 

I noticed the patch is marked as "Changes Requested", is there some 
action pending from me?

Thanks,
Fernando.

  reply	other threads:[~2026-02-14 13:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 20:20 [PATCH net] ipv6: addrconf: reduce default temp_valid_lft to 2 days Fernando Fernandez Mancera
2026-02-13 14:00 ` Simon Horman
2026-02-13 14:34   ` Eric Dumazet
2026-02-13 14:44     ` Fernando Fernandez Mancera
2026-02-14 13:27       ` Fernando Fernandez Mancera [this message]
2026-02-14 13:37         ` Eric Dumazet
2026-02-14 13:43           ` Fernando Fernandez Mancera
2026-02-15  9:16             ` Fernando Gont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89d03f27-2e08-4619-b556-772da4c38462@suse.de \
    --to=fmancera@suse.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fgont@si6networks.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox