From: Jacob Keller <jacob.e.keller@intel.com>
To: Philipp Stanner <phasta@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Yanteng Si <si.yanteng@linux.dev>,
"Huacai Chen" <chenhuacai@kernel.org>,
Yinggang Gu <guyinggang@loongson.cn>,
"Serge Semin" <fancer.lancer@gmail.com>,
Philipp Stanner <pstanner@redhat.com>
Cc: <netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Henry Chen <chenx97@aosc.io>
Subject: Re: [PATCH net-next 2/3] stmmac: Remove pcim_* functions for driver detach
Date: Thu, 13 Mar 2025 15:33:19 -0700 [thread overview]
Message-ID: <89d99e2f-1189-42dc-8284-bab874820aa4@intel.com> (raw)
In-Reply-To: <20250313161422.97174-4-phasta@kernel.org>
On 3/13/2025 9:14 AM, Philipp Stanner wrote:
> Functions prefixed with "pcim_" are managed devres functions which
> perform automatic cleanup once the driver unloads. It is, thus, not
> necessary to call any cleanup functions in remove() callbacks.
>
> Remove the pcim_ cleanup function calls in the remove() callbacks.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Yanteng Si <si.yanteng@linux.dev>
> Tested-by: Henry Chen <chenx97@aosc.io>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2025-03-13 22:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 16:14 [PATCH net-next 0/3] Clean up deprecated PCI calls Philipp Stanner
2025-03-13 16:14 ` [PATCH net-next 1/3] stmmac: loongson: Remove surplus loop Philipp Stanner
2025-03-13 22:32 ` Jacob Keller
2025-03-13 16:14 ` [PATCH net-next 2/3] stmmac: Remove pcim_* functions for driver detach Philipp Stanner
2025-03-13 22:33 ` Jacob Keller [this message]
2025-03-13 16:14 ` [PATCH net-next 3/3] stmmac: Replace deprecated PCI functions Philipp Stanner
2025-03-13 22:34 ` Jacob Keller
2025-03-18 17:50 ` [PATCH net-next 0/3] Clean up deprecated PCI calls Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89d99e2f-1189-42dc-8284-bab874820aa4@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=chenhuacai@kernel.org \
--cc=chenx97@aosc.io \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=guyinggang@loongson.cn \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phasta@kernel.org \
--cc=pstanner@redhat.com \
--cc=si.yanteng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).