From: Kumar Gala <galak@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: afleming@freescale.com, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Add TBI PHY node to first MDIO bus
Date: Wed, 7 Dec 2011 15:52:10 -0600 [thread overview]
Message-ID: <8E6B8366-A254-4528-8327-91710BD0C68D@kernel.crashing.org> (raw)
In-Reply-To: <20111207.150208.588206951117780997.davem@davemloft.net>
On Dec 7, 2011, at 2:02 PM, David Miller wrote:
> From: Andy Fleming <afleming@freescale.com>
> Date: Wed, 7 Dec 2011 13:50:57 -0600
>
>> Systems which use the fsl_pq_mdio driver need to specify an
>> address for TBI PHY transactions such that the address does
>> not conflict with any PHYs on the bus (all transactions to
>> that address are directed to the onboard TBI PHY). The driver
>> used to scan for a free address if no address was specified,
>> however this ran into issues when the PHY Lib was fixed so
>> that all MDIO transactions were protected by a mutex. As it
>> is, the code was meant to serve as a transitional tool until
>> the device trees were all updated to specify the TBI address.
>>
>> The best fix for the mutex issue was to remove the scanning code,
>> but it turns out some of the newer SoCs have started to omit
>> the tbi-phy node when SGMII is not being used. As such, these
>> devices will now fail unless we add a tbi-phy node to the first
>> mdio controller.
>>
>> Signed-off-by: Andy Fleming <afleming@freescale.com>
>> ---
>>
>> This requires fsl_pq_mdio: Clean up tbi address configuration from
>> the net tree in order to achieve its full effect.
>>
>> This needs to go into 3.2.
>
> I'm fine if the powerpc tree takes this one:
>
> Acked-by: David S. Miller <davem@davemloft.net>
Will pull in via PPC tree.
- k
next prev parent reply other threads:[~2011-12-07 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 19:50 [PATCH] powerpc: Add TBI PHY node to first MDIO bus Andy Fleming
2011-12-07 20:02 ` David Miller
2011-12-07 21:52 ` Kumar Gala [this message]
2011-12-08 7:23 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E6B8366-A254-4528-8327-91710BD0C68D@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox