Re: phylib interrupt question

[Andy Fleming <afleming@freescale.com>]

On Jun 6, 2008, at 12:11, Andy Fleming wrote:

>
> On Jun 6, 2008, at 11:07, steve.glendinning@smsc.com wrote:
>
>> Hi everybody,
>>
>> I'm converting an ethernet driver to use phylib, and I have an  
>> interrupt
>> question.  My device is an integrated mac/phy, with the option to  
>> disable
>> the internal phy and use an external phy instead.  I've succesfully  
>> used
>> phylib in polling mode, but I'd like to convert this to be
>> interrupt-driven if possible.
>>
>> When using the internal phy, it can raise interrupts via the mac (by
>> setting a "phy interrupt" bit in the mac's interrupt status  
>> register).  Is
>> there a way of signalling this phy interrupt to phylib from my mac
>> driver's isr?  Phylib seems to want to connect to a real irq?
>
> Hm.  Looks like one of the features of Phylib got accidentally  
> dropped.  However, it's a simple 2-line fix which I'm about to submit.


D'oh, I'm totally wrong about that being a bug.  Both of the places  
that check phydev->irq != PHY_POLL are valid.  Good news is: that  
means you don't need to wait for a patch!

Andy