From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarod Wilson Subject: Re: [PATCH net] sfc: pass valid pointers from efx_enqueue_unwind Date: Fri, 8 Dec 2017 10:37:00 -0500 Message-ID: <8a3c0588-dbe3-e129-7055-de0ece332fc9@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com To: Bert Kenward , Dave Miller Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50932 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754120AbdLHPg7 (ORCPT ); Fri, 8 Dec 2017 10:36:59 -0500 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2017-12-07 12:18 PM, Bert Kenward wrote: > The bytes_compl and pkts_compl pointers passed to efx_dequeue_buffers > cannot be NULL. Add a paranoid warning to check this condition and fix > the one case where they were NULL. > > efx_enqueue_unwind() is called very rarely, during error handling. > Without this fix it would fail with a NULL pointer dereference in > efx_dequeue_buffer, with efx_enqueue_skb in the call stack. > > Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2") > Reported-by: Jarod Wilson > Signed-off-by: Bert Kenward I didn't have the warn, but the rest is identical to what I did locally to get around this when I was hitting it. Tested-by: Jarod Wilson Acked-by: Jarod Wilson -- Jarod Wilson jarod@redhat.com