From: Alexey Dobriyan <adobriyan@gmail.com>
To: Lin Ma <linma@zju.edu.cn>
Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, simon.horman@corigine.com
Subject: Re: [PATCH v2] net: xfrm: Fix xfrm_address_filter OOB read
Date: Sun, 25 Jun 2023 17:07:11 +0300 [thread overview]
Message-ID: <8a80ec0b-154a-4e6c-8fb8-916f506cd26d@p183> (raw)
> + if (filter->splen >= (sizeof(xfrm_address_t) << 3) ||
> + filter->dplen >= (sizeof(xfrm_address_t) << 3)) {
Please multiply by 8 if you want to multiply by 8.
Should it be "splen > 8 * sizeof()" ?
next reply other threads:[~2023-06-25 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 14:07 Alexey Dobriyan [this message]
2023-06-26 1:20 ` [PATCH v2] net: xfrm: Fix xfrm_address_filter OOB read Lin Ma
-- strict thread matches above, loose matches on Subject: below --
2023-06-25 13:48 Lin Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a80ec0b-154a-4e6c-8fb8-916f506cd26d@p183 \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linma@zju.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox