* [PATCH] selftests: rds: Remove include.sh when make clean
@ 2024-09-27 4:49 zhangjiao2
2024-10-03 0:23 ` Jakub Kicinski
2024-10-03 22:16 ` Allison Henderson
0 siblings, 2 replies; 3+ messages in thread
From: zhangjiao2 @ 2024-09-27 4:49 UTC (permalink / raw)
To: davem
Cc: edumazet, kuba, pabeni, shuah, netdev, linux-rdma, rds-devel,
zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Remove include.sh when make clean
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/net/rds/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
index da9714bc7aad..0b697669ea51 100644
--- a/tools/testing/selftests/net/rds/Makefile
+++ b/tools/testing/selftests/net/rds/Makefile
@@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
include.sh \
test.py
-EXTRA_CLEAN := /tmp/rds_logs
+EXTRA_CLEAN := /tmp/rds_logs include.sh
include ../../lib.mk
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: rds: Remove include.sh when make clean
2024-09-27 4:49 [PATCH] selftests: rds: Remove include.sh when make clean zhangjiao2
@ 2024-10-03 0:23 ` Jakub Kicinski
2024-10-03 22:16 ` Allison Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-10-03 0:23 UTC (permalink / raw)
To: zhangjiao2; +Cc: davem, edumazet, pabeni, shuah, netdev, linux-rdma, rds-devel
On Fri, 27 Sep 2024 12:49:23 +0800 zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Remove include.sh when make clean
I don't understand why. At the very least you need to improve the
commit message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: rds: Remove include.sh when make clean
2024-09-27 4:49 [PATCH] selftests: rds: Remove include.sh when make clean zhangjiao2
2024-10-03 0:23 ` Jakub Kicinski
@ 2024-10-03 22:16 ` Allison Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Allison Henderson @ 2024-10-03 22:16 UTC (permalink / raw)
To: zhangjiao2@cmss.chinamobile.com, davem@davemloft.net
Cc: linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
shuah@kernel.org, edumazet@google.com, kuba@kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
On Fri, 2024-09-27 at 12:49 +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Remove include.sh when make clean
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Hi Zhang,
Thanks for the patch, but it looks like Javier submitted the same fix
around the same time.
https://patchwork.kernel.org/project/linux-rdma/patch/20240924-selftests-gitignore-v1-2-9755ac883388@gmail.com/
I've already given the rvb the other version, but thank you for
catching this anyway!
Allison
> ---
> tools/testing/selftests/net/rds/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/rds/Makefile
> b/tools/testing/selftests/net/rds/Makefile
> index da9714bc7aad..0b697669ea51 100644
> --- a/tools/testing/selftests/net/rds/Makefile
> +++ b/tools/testing/selftests/net/rds/Makefile
> @@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
> include.sh \
> test.py
>
> -EXTRA_CLEAN := /tmp/rds_logs
> +EXTRA_CLEAN := /tmp/rds_logs include.sh
>
> include ../../lib.mk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-03 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 4:49 [PATCH] selftests: rds: Remove include.sh when make clean zhangjiao2
2024-10-03 0:23 ` Jakub Kicinski
2024-10-03 22:16 ` Allison Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).