Re: [PATCH net-next v2 13/14] dibs: Move data path to dibs layer

[Alexandra Winter <wintera@linux.ibm.com>]

On 16.09.25 10:19, Paolo Abeni wrote:
> On 9/11/25 9:48 PM, Alexandra Winter wrote:
>> +static void __dibs_lo_unregister_dmb(struct dibs_lo_dev *ldev,
>> +				     struct dibs_lo_dmb_node *dmb_node)
>> +{
>> +	/* remove dmb from hash table */
>> +	write_lock_bh(&ldev->dmb_ht_lock);
>> +	hash_del(&dmb_node->list);
>> +	write_unlock_bh(&ldev->dmb_ht_lock);
>> +
>> +	clear_bit(dmb_node->sba_idx, ldev->sba_idx_mask);
>> +	kvfree(dmb_node->cpu_addr);
>> +	kfree(dmb_node);
> 
> I see the above comes directly from existing code, but it's not clear to
> me where (and if) dmb_node->cpu_addr is vmalloc()ed (as opposed to
> kmalloc()ed).
> 
> Could you consider switching to kfree() (if possible/applicable) and/or
> add a describing comment if not?
> 
> Thanks,
> 
> Paolo
> 


Yes, that makes sense to me, thank you very much.
I'll do

- kvfree(dmb_node->cpu_addr);
+ kfree(dmb_node->cpu_addr);

in v3.