From: David Ahern <dsahern@gmail.com>
To: Charles McLachlan <cmclachlan@solarflare.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com,
brouer@redhat.com
Subject: Re: [PATCH net-next v2 0/6] sfc: Add XDP support
Date: Mon, 28 Oct 2019 16:03:13 -0600 [thread overview]
Message-ID: <8af30fef-6998-ed20-ba7c-982c9a4d263a@gmail.com> (raw)
In-Reply-To: <74c15338-c13e-5b7b-9cc5-844cd9262be3@solarflare.com>
On 10/28/19 7:56 AM, Charles McLachlan wrote:
> Supply the XDP callbacks in netdevice ops that enable lower level processing
> of XDP frames.
>
> Changes since last submission:
> - Use of xdp_return_frame_rx_napi() in tx.c
> - Addition of xdp_rxq_info_valid and xdp_rxq_info_failed to track when
> xdp_rxq_info failures occur.
> - Renaming of rc to err and more use of unlikely().
> - Cut some duplicated code and fix an array overrun.
> - Actually increment n_rx_xdp_tx when packets are transmitted.
>
>
Hi:
I was hoping to try out this patch set, but when I rebooted the server
with these applied I hit the BUG_ON in efx_ef10_link_piobufs:
if (tx_queue->queue == nic_data->pio_write_vi_base) {
BUG_ON(index != 0);
...
next prev parent reply other threads:[~2019-10-28 22:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 13:56 [PATCH net-next v2 0/6] sfc: Add XDP support Charles McLachlan
2019-10-28 13:59 ` [PATCH net-next v2 1/6] sfc: support encapsulation of xdp_frames in efx_tx_buffer Charles McLachlan
2019-10-28 13:59 ` [PATCH net-next v2 2/6] sfc: perform XDP processing on received packets Charles McLachlan
2019-10-28 16:33 ` Jesper Dangaard Brouer
2019-10-28 17:11 ` Charles McLachlan
2019-10-28 17:46 ` Edward Cree
2019-10-28 18:05 ` David Miller
2019-10-28 13:59 ` [PATCH net-next v2 3/6] sfc: Enable setting of xdp_prog Charles McLachlan
2019-10-28 13:59 ` [PATCH net-next v2 4/6] sfc: allocate channels for XDP tx queues Charles McLachlan
2019-10-28 14:00 ` [PATCH net-next v2 5/6] sfc: handle XDP_TX outcomes of XDP eBPF programs Charles McLachlan
2019-10-28 14:00 ` [PATCH net-next v2 6/6] sfc: add XDP counters to ethtool stats Charles McLachlan
2019-10-28 22:03 ` David Ahern [this message]
2019-10-29 9:40 ` [PATCH net-next v2 0/6] sfc: Add XDP support Charles McLachlan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af30fef-6998-ed20-ba7c-982c9a4d263a@gmail.com \
--to=dsahern@gmail.com \
--cc=brouer@redhat.com \
--cc=cmclachlan@solarflare.com \
--cc=davem@davemloft.net \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox